Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] test: fix/rename test/debugger/helper-debugger-* #13269

Closed
wants to merge 0 commits into from
Closed

[WIP] test: fix/rename test/debugger/helper-debugger-* #13269

wants to merge 0 commits into from

Conversation

rhoboat
Copy link

@rhoboat rhoboat commented May 28, 2017 •
edited
Loading

Addresses #12742

Tracking

  • test/debugger/test-debugger-repl-break-in-module.js
  • test/debugger/test-debugger-repl-restart.js
  • test/debugger/test-debugger-repl-term.js
  • test/debugger/test-debugger-repl-utf8.js
  • test/debugger/helper-debugger-repl.js
  • test/debugger/test-debugger-repl.js

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Affected core subsystem(s)

@mscdex
Copy link
Contributor

mscdex commented May 28, 2017

The commit has no changes?

@refack refack added the wip Issues and PRs that are still a work in progress. label May 28, 2017
@refack refack changed the title test: fix/rename test/debugger/helper-debugger-* [WIP] test: fix/rename test/debugger/helper-debugger-* May 28, 2017
@refack refack added debugger inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels May 28, 2017
@refack refack self-assigned this May 28, 2017
@rhoboat rhoboat closed this May 29, 2017
@rhoboat
Copy link
Author

rhoboat commented May 29, 2017

I didn't intend to merge this with no changes. I had rebased over latest master from command line, and that somehow merged the branch. Will fix that.

@refack
Copy link
Contributor

refack commented May 29, 2017

Once it has some commits, it's easy to reopen.

@refack refack mentioned this pull request Jun 11, 2017
Closed
@refack refack removed their assignment Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhoboat @mscdex @refack