-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WHATWG URL throw parse error for valid domains #12965
Comments
On the spec side of things: This is a known issue of the URL Standard and Unicode Technical Standard UTS#46 (which specifies IDNA processing used by WHATWG's standard). A fix to UTS#46 is scheduled to be released in tandem with Unicode 10.0.0 next month. See:
On the implementation side, a future ICU4C update with the possibility to disable the CheckHyphens flag will resolve this, but a solution like #12966 which uses existing error handling infrastructure should be robust also (already used for several other error conditions we explicitly filter out). |
To match browser behavior fast path ascii only domains and do not run ToASCII on them. Fixes: nodejs#12965 Refs: nodejs#12966 Refs: whatwg/url#309
To match browser behavior fast path ascii only domains and do not run ToASCII on them. Fixes: nodejs#12965 Refs: nodejs#12966 Refs: whatwg/url#309
To match browser behavior fast path ascii only domains and do not run ToASCII on them. Fixes: nodejs#12965 Refs: nodejs#12966 Refs: whatwg/url#309
To match browser behavior fast path ascii only domains and do not run ToASCII on them. Fixes: nodejs#12965 Refs: nodejs#12966 Refs: whatwg/url#309
To match browser behavior fast path ascii only domains and do not run ToASCII on them. Fixes: nodejs#12965 Refs: nodejs#12966 Refs: whatwg/url#309
To match browser behavior fast path ascii only domains and do not run ToASCII on them. Fixes: nodejs#12965 Refs: nodejs#12966 Refs: whatwg/url#309
There are valid domain names with hyphens at 3 and 4th position, new node WHATWG URL parser was failing for it assume its an invalid IDN. Fixes: nodejs#12965
There are valid domain names with hyphens at 3 and 4th position, new node WHATWG URL parser was failing for it assume its an invalid IDN. Also filters IDN errors when domain label start or end with hyphen. Fixes: nodejs#12965 Refs: https://www.icann.org/news/announcement-2000-01-07-en
There are valid domain names with hyphens at 3 and 4th position, new node WHATWG URL parser was failing for it assume its an invalid IDN. Also filters IDN errors when domain label start or end with hyphen. Fixes: nodejs#12965 Refs: https://www.icann.org/news/announcement-2000-01-07-en
There are valid domain names with hyphens at 3 and 4th position, new node WHATWG URL parser was failing for it assume its an invalid IDN. Also filters IDN errors when domain label start or end with hyphen. Also fix error in ToUnicode Fixes: nodejs#12965 Refs: https://www.icann.org/news/announcement-2000-01-07-en Refs: whatwg/url#309 (comment)
Some valid urls which are present in wild are not parsed properly by node new WHATWG URL.
Test Case:
http://r4---sn-a5mlrn7s.googlevideo.com/videoplayback?expire=1494484646&ei=RrITWaW1NuSS_AP_lon4CA&ipbits=0&requiressl=yes&signature=6469DE4B7CA90E4AB500FCD9159353290459853C.777DACAAC24135B25C0AB15D95B29BD393680B1B&clen=2156644&source=youtube&pl=24&gir=yes&sparams=clen,ctier,dur,ei,expire,gir,id,initcwndbps,ip,ipbits,ipbypass,itag,lmt,mime,mm,mn,ms,mv,pl,requiressl,source,upn&ctier=L&upn=MMHgTKY6mis&mime=video%2Fmp4&id=o-AMLnIjkDX1gx21rmlzdY1VkQHY-kXzFKaFA2iFuP855X&itag=133&dur=79.566&lmt=1478637905535062&key=cms1&ip=159.180.74.11&alr=yes&keepalive=yes&ratebypass=yes&cpn=FydMiT6Ke_Z-kkwz&c=WEB&cver=1.20170509&range=0-949&rn=119&playerretry=3&rbuf=0&redirect_counter=1&req_id=78c3fd24619094be&cms_redirect=yes&ipbypass=yes&mm=26&mn=sn-a5mlrn7s&ms=onr&mt=1494468503
Above url is from google videos/youtube and works as expected in browsers.
The text was updated successfully, but these errors were encountered: