-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release proposal: v1.6.4 #1340
Comments
Hmm, changelog maker is a little confused because the last tag is somehow on an orphaned commit. npm@2.7.4 landed in the last release, 1.6.3. Edit: fixed manually.. |
Update: Both #1337 and #1323 have landed. @rvagg Should we make changelog-maker truncate names?
|
Also worth noting: @iojs/collaborators please don't merge anything |
I will merge #1325 after releasing this. |
@Fishrock123 I've just merge #1325. Please add them to the list. |
@Fishrock123 can you do a And no, don't truncate names, that's a little disrespectful IMO Next job: craft the changelog entry that goes above the commit list and iterate on it in here. I'm +1 on moving this out fairly quickly given that we have a decent sized list and the npm bugfix is worth getting in to people's hands. |
Already done that once :) |
@Fishrock123 do you have the latest
|
oh sorry, I see that npm@2.7.4 commit isn't in your list now, must have fixed it on your end already |
@rvagg I keep having to remove it by hand. The git is going to be weird until the next tag, apparently. |
@Fishrock123 maybe |
Here's the git command it should be running to get the list:
It'll manually prune the two commits at the beginning from the last release. |
I have an alias setup to do |
@rvagg that command stalls for me, but I got the one from the releases doc to work earlier. I thought we used changelog-maker for this..? |
changelog-maker runs the above git command internally |
Sorry, I had been running Perhaps it is tagged right (but incorrectly) on your end? See: https://gist.github.com/Fishrock123/f01006c81762364d376e |
Related: nodejs/node#1340 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
PR-URL: nodejs#49 Related: nodejs/node#1340 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
OK, I don't understand what's going on, perhaps one of the git geniuses from @iojs/tc can help explain. It's very possible that I messed 1.6.3 up somehow, it was done in a hurry but it's still pretty straight-forward so I can't see how, I also can't find evidence of a force push that would mess things up. e5d1a42 is the commit I tagged and was used for release and apparently orphaned. 4845f9c is identical and on v1.x and not the tagged one. @Fishrock123 changelog-maker is still working for me because it works on tag date, see it on a fresh clone here: https://gist.github.com/rvagg/d865c151ef31cb5d4457 @iojs/tc should I delete that tag and re-tag 4845f9c so it's on v1.x? It appears to be identical. |
@rvagg I say delete and retag. |
I'll do that then. @Fishrock123 don't let this hold up a release. One thing to be aware of when promoting the builds--you'll get some permission errors, these are inconsequential and can be ignored, they are related to cleaning out the staging directory and don't impact promotion. They are kind of noisy and make it look bad but they are not a big deal. |
re-tagged v1.6.3 |
I sorta had been because of
Ok, I'll try to get a changelog out here today, but family things may be happening, so if I don't and someone else has more time that'd be great. Speaking of which, how do we compile NPM's changelog? |
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/443/ Also, changelog-maker is working fine with the fixed tag. |
Anyone have better wording for this?
(I can re-add #1075 as an existing issue, but I believe we can confidently say it isn't anymore.) |
2015-03-31, Version 1.6.4, @Fishrock123Notable changes
Known issues
Commits |
This is new on win2008r2.. windows config issue maybe?
Building a nightly: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/126/ |
@Fishrock123 I've been putting deps at the bottom of the list of notable changes, and can I suggest you change the openssl one to be prefixed with I think I've seen that win2008 failure before so I wouldn't let it hold you up. Here's another run I just did for another purpose where it's passed just fine: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/444/nodes=iojs-win2008r2/console |
Sure, but here they are the important bits..
Yup, will do. @rvagg how do you feel about this bit in particular, and in terms of removing #1075 from "known issues"?
|
Can we perhaps get #1350 in (assuming others want it) so we don't grow the tarball for "no" reason? |
@Fishrock123 yeah that timers bit sounds fine, I'd err on the side of caution and still report possible leak in Known issues _but_ it seems like we may be close enough to remove it so it's a judgement call for you to make since this is your release. @jbergstroem there's enough LGTM's in there so it's up to @shigeki as to whether he can land it in time but I'd suggest that this release is ready to roll so could be pushed out right now so #1350 may have to wait till the next release. |
(#1350 just landed) |
Updated CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/446/ |
I don't know if this is relevant but,
|
@gabeio it's not promoted yet, please stand by. (yay gpg subkey fun!) |
ah ok sorry wasn't sure I just |
Yeah, it (possibly erroneously) updates the |
@gabeio It should work now. (note: armv6 takes much longer to build and will be uploaded later.) |
yup thanks! |
Whoops, thanks @silverwind! |
This is primarily to get npm@2.7.5 (#1337) in somewhat quick, as it fixes a bug with installing private git deps (#1323), and contains some security fixes.
It may also be possible to get some of @indutny's timer unref fixes in from #1330 if everything proves stable.
3a69b7689b
] - benchmark: add rsa/aes-gcm performance test (Shigeki Ohtsu) iojs/io.js#13251c709f3aa9
] - benchmark: add/remove hash algorithm (Shigeki Ohtsu) iojs/io.js#1325a081c7c522
] - benchmark: fix chunky client benchmark execution (Brian White) iojs/io.js#125765d4d25f52
] - build: default to armv7+vfpv3 for android (Giovanny Andres Gongora Granada) iojs/io.js#13076a134f7d70
] - build: avoid passing private flags from pmake (Johan Bergström) iojs/io.js#13345094a0fde3
] - build: Pass BSDmakefile args to gmake (Johan Bergström) iojs/io.js#1298f782824d48
] - deps: refactor openssl.gyp (Shigeki Ohtsu) iojs/io.js#132521f4fb6215
] - deps: update gyp to e1c8fcf7 (Shigeki Ohtsu) iojs/io.js#1325dac903f9b6
] - deps: make node-gyp work with io.js (cjihrig) iojs/io.js#9905eb983e0b3
] - deps: upgrade npm to 2.7.5 (Forrest L Norvell) iojs/io.js#1337008078862e
] - deps: check in gtest, add util unit test (Ben Noordhuis) iojs/io.js#119948d69cf1bb
] - _Revert_ "doc: fix typo in CHANGELOG.md" (Giovanny Andres Gongora Granada) iojs/io.js#1349679596c848
] - doc: add Docker WG (Peter Petrov) iojs/io.js#1134d8578bad25
] - doc: fix minor typos in COLLABORATOR_GUIDE.md (Kelsey) iojs/io.js#1320bde2b3e397
] - doc: fix typo in CHANGELOG.md (Giovanny Andres Gongora Granada) iojs/io.js#13428c6c376a94
] - doc: add GPG fingerprint for Fishrock123 (Jeremiah Senkpiel) iojs/io.js#1324ccbea18960
] - doc: better formatting for collaborator GPG keys (Jeremiah Senkpiel) iojs/io.js#132487053e8aee
] - doc: add back quote to boolean variable 'true' (Kohei TAKATA) iojs/io.js#1338634e9629a0
] - doc: add TC meeting minutes 2015-03-04 (Rod Vagg) iojs/io.js#1123245ba1d658
] - doc: fix util.isObject documentation (Jeremiah Senkpiel) iojs/io.js#1295ad937752ee
] - doc,src: remove references to --max-stack-size (Aria Stewart) iojs/io.js#132715f058f609
] - gyp: fix build with python 2.6 (Fedor Indutny) iojs/io.js#13254dc6ae2181
] - lib: remove unused variables (Brian White) iojs/io.js#1290b6e22c4bd5
] - src: setup cluster workers before preloading (Ali Ijaz Sheikh) iojs/io.js#13144a801c211c
] - src: drop homegrown thread pool, use libplatform (Ben Noordhuis) iojs/io.js#1329f1e5a13516
] - src: wrap MIN definition in infdef (Johan Bergström) iojs/io.js#13226f72d87c27
] - test: add test for a unref'ed timer leak (Fedor Indutny) iojs/io.js#1330416499c872
] - timers: remove redundant code (Fedor Indutny) iojs/io.js#1330d22b2a934a
] - timers: do not restart the interval after close (Fedor Indutny) iojs/io.js#1330cca5efb086
] - timers: don't close interval timers when unrefd (Julien Gilli)0e061975d7
] - timers: fix unref() memory leak (Trevor Norris) iojs/io.js#1330ec7fbf2bb2
] - tools: fix install source path for openssl headers (Oguz Bastemur) iojs/io.js#1354644ece1f67
] - tools: remove gyp test directory (Shigeki Ohtsu) iojs/io.js#1350eb459c8151
] - tools: fix gyp to work on MacOSX without XCode (Shigeki Ohtsu) iojs/io.js#13251e94057c05
] - url: fix resolving from non-file to file URLs. (Jeffrey Jagoda) iojs/io.js#1277382bd9d2e0
] - v8: back-port openbsd/amd64 build fix (Ben Noordhuis) iojs/io.js#1318efadffe861
] - win,node-gyp: optionally allow node.exe/iojs.exe to be renamed (Bert Belder) iojs/io.js#1266/cc @rvagg
The text was updated successfully, but these errors were encountered: