Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel/test-http-client-get-url - Intermittent on OSX ? #13507

Closed
mhdawson opened this issue Jun 6, 2017 · 1 comment
Closed

parallel/test-http-client-get-url - Intermittent on OSX ? #13507

mhdawson opened this issue Jun 6, 2017 · 1 comment
Labels
http Issues or PRs related to the http subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jun 6, 2017

  • Version: master
  • Platform: OSX
  • Subsystem:

Failure in CI run for unrelated change:

https://ci.nodejs.org/job/node-test-commit-osx/10321/nodes=osx1010/console

not ok 547 parallel/test-http-client-get-url
  ---
  duration_ms: 0.247
  severity: fail
  stack: |-
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: connect ECONNRESET 127.0.0.1:61573
        at Object.exports._errnoException (util.js:1012:11)
        at exports._exceptionWithHostPort (util.js:1035:20)
        at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1136:14)
  ...
@mscdex mscdex added http Issues or PRs related to the http subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests. labels Jun 6, 2017
@mhdawson mhdawson mentioned this issue Jun 6, 2017
Closed
4 tasks
@sebastianplesciuc
Copy link

A similar test for this flaked for https here. I'll try to make a fix for this like this one.

@sebastianplesciuc sebastianplesciuc mentioned this issue Jun 7, 2017
Closed
3 tasks
@refack refack closed this as completed in 61adb26 Jun 11, 2017
addaleax pushed a commit that referenced this issue Jun 12, 2017
@addaleax
test: fix flaky test-http-client-get-url
4c5457f 
Fixed test-http-client-get-url by waiting on HTTP GET
requests to finish before closing the server.

PR-URL: #13516
Fixes: #13507
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @mhdawson @sebastianplesciuc