Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mips64el should be listed in configure's valid_arch ? #13616

Closed
kapouer opened this issue Jun 11, 2017 · 3 comments
Closed

mips64el should be listed in configure's valid_arch ? #13616

kapouer opened this issue Jun 11, 2017 · 3 comments
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. mips Issues and PRs related to the MIPS architecture.

Comments

@kapouer
Copy link
Contributor

kapouer commented Jun 11, 2017

In Node versions 6.11.0 and all other branches released at the same time, it seems that mips64el is not listed in valid_arch.
As a consequence, it is supported only if one doesn't set it through --dest-cpu and rely only on automatic selection of host arch.
@mscdex mscdex added build Issues and PRs related to build files or the CI. mips Issues and PRs related to the MIPS architecture. labels Jun 11, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 11, 2017

So mips64el needs to be added to configure#L50, seems reasonable.

@gibfahn gibfahn added the good first issue Issues that are suitable for first-time contributors. label Jun 11, 2017
@thelostone-mc
Copy link
Contributor

Is this still up for grabs ?

@gibfahn
Copy link
Member

gibfahn commented Jun 11, 2017

Is this still up for grabs ?

Go for it!

@thelostone-mc thelostone-mc mentioned this issue Jun 11, 2017
Closed
2 tasks
thelostone-mc added a commit to thelostone-mc/node that referenced this issue Jun 12, 2017
@thelostone-mc
configure: add mips64el to valid_arch
4809aff 
Fixes: nodejs#13616
addaleax pushed a commit that referenced this issue Jun 17, 2017
@thelostone-mc @addaleax
configure: add mips64el to valid_arch
624e655 
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax pushed a commit that referenced this issue Jun 21, 2017
@thelostone-mc @addaleax
configure: add mips64el to valid_arch
465bd48 
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue Jul 17, 2017
@thelostone-mc @MylesBorins
configure: add mips64el to valid_arch
a5f3b6f 
PR-URL: #13620
Fixes: #13616
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. good first issue Issues that are suitable for first-time contributors. mips Issues and PRs related to the MIPS architecture.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: added mips64el to valid_arch thelostone-mc/node
4 participants
@mscdex @kapouer @thelostone-mc @gibfahn