Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor test/inspector #13622

Closed
Trott opened this issue Jun 11, 2017 · 9 comments
Closed

refactor test/inspector #13622

Trott opened this issue Jun 11, 2017 · 9 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Jun 11, 2017

  • Version: master
  • Platform: all
  • Subsystem: inspector

Especially now that it's not experimental, it seems that it would make sense to:

  • move the tests in test/inspector into test/sequential and/or test/parallel as appropriate
  • move the test/inspector/global-functions.js into test/fixtures
  • move test/inspector-helper.js to test/common/inspector-helper.js

Basically, get rid of the inspector-specific directory.

Or is there real benefit to having it all in its own directory?

@nodejs/testing

@Trott Trott added inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Jun 11, 2017
@refack
Copy link
Contributor

refack commented Jun 11, 2017

Only thing I can think of, is that we don't have enough coverage (cli options #8080 & #13002, new features #11431 & #13228 & #13350) and we are working on merging with /debugger/ #13269
So maybe wait a little while longer?

@thelostone-mc
Copy link
Contributor

@refack A rough estimate on when the merging would be done ?

@refack
Copy link
Contributor

refack commented Jun 20, 2017

@refack A rough estimate on when the merging would be done?

Hopefully < 1 month 🤷‍♂️

@thelostone-mc
Copy link
Contributor

Permission to call dibs now for this ? :P

@refack refack added the wip Issues and PRs that are still a work in progress. label Jun 20, 2017
@refack refack assigned refack and unassigned refack Jun 20, 2017
@refack
Copy link
Contributor

refack commented Jun 20, 2017

Permission to call dibs now for this ? :P

I think in general it's a "better to ask forgiveness than permission" situation.
Flagged as in progress.

@refack
Copy link
Contributor

refack commented Jun 20, 2017

@adityaanandmc how are you with python?

@thelostone-mc
Copy link
Contributor

thelostone-mc commented Jun 24, 2017

@refack fairly alright! Plus if all else fails, there is google/duckduckgo to help me out

Do you have something in mind I can help out with ?

@maclover7
Copy link
Contributor

Should be able to be closed since #16197 was merged (Refs didn't make it in unfortunately 😞)

@refack
Copy link
Contributor

refack commented Oct 18, 2017

(Refs didn't make it in unfortunately 😞)

I think the metadata generator needs the Refs: line to have only the link
image
Also refs doesn't close bugs, only "Fixed:"

@refack refack closed this as completed Oct 18, 2017
@Trott Trott removed the wip Issues and PRs that are still a work in progress. label Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants