-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making base64 cctest deterministic makes it fail #13636
Comments
Not familiar with cctest. How do I run (or preferably, debug) them? |
@seishun You can run them with |
Great, so you can just debug
In theory, yes. In practice, I'll try to look into what's going on in |
You could try to filter using
Makes sense… :/ |
The following patch makes the
base64
cctest fail for me:That shouldn’t be happening, because
buffer
might be 0-initialized anyway. Without this patch, valgrind complains that we use uninitialized parts ofbuffer
(rightfully so, I assume).I don’t have the time to look into this right now, but I assume either the test is just asserting the wrong values, or something’s off with our base64 decoder implementation.
/cc @aqrln @seishun
The text was updated successfully, but these errors were encountered: