Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcbuild.bat fails with "input line too long" #13765

Closed
tniessen opened this issue Jun 18, 2017 · 3 comments · Fixed by #13806
Closed

vcbuild.bat fails with "input line too long" #13765

tniessen opened this issue Jun 18, 2017 · 3 comments · Fixed by #13806
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@tniessen
Copy link
Member

tniessen commented Jun 18, 2017 •
edited
Loading

  • Version: master
  • Platform: Windows x64 with Visual Studio 2015
  • Subsystem: vcbuild

Running vcbuild.bat appends data to the PATH environment variable. After several runs, the value of the variable becomes so long that VC batch files crash with an error message saying "Input line is too long", which is not really surprising considering the relatively small limit of about 8k for command lines on Windows.

This line calls a number of batch scripts which configure the environment to use the VS2015 toolchain:

call "%VS140COMNTOOLS%\..\..\vc\vcvarsall.bat"

This answer might offer a solution to the problem:

if not defined DevEnvDir (
    call vcvarsall.bat
)

However, I am not too familiar with VC-internal batch files and have no idea about side-effects or alternatives, so any insights would be useful here.

@seishun was able to reproduce this on VS2015, but not on VS2017.
@tniessen tniessen added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jun 18, 2017
@tniessen
Copy link
Member Author

/cc @nodejs/platform-windows

@seishun
Copy link
Contributor

seishun commented Jun 18, 2017

cc @refack

@refack
Copy link
Contributor

refack commented Jun 20, 2017

This is a regression introduced in 780acc2.
A fix PR is coming.

@refack refack mentioned this issue Jun 20, 2017
Merged
2 tasks
refack added a commit to refack/node that referenced this issue Jul 9, 2017
@refack
build,win: skip vcvarsall.bat if env is set
8206a01 
PR-URL: nodejs#13806
Fixes: nodejs#13765
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack refack mentioned this issue Jul 9, 2017
Merged
2 tasks
addaleax pushed a commit that referenced this issue Jul 11, 2017
@refack @addaleax
build,win: skip vcvarsall.bat if env is set
6ac4e94 
PR-URL: #13806
Fixes: #13765
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this issue Jul 18, 2017
@refack @addaleax
build,win: skip vcvarsall.bat if env is set
897405d 
PR-URL: #13806
Fixes: #13765
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this issue Jul 19, 2017
@refack @Fishrock123
build,win: skip vcvarsall.bat if env is set
9675734 
PR-URL: #13806
Fixes: #13765
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build,win: skip vcvarsall if already set refack/node
3 participants
@refack @seishun @tniessen