Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node install destroyed PATH #14135

Closed
ofek opened this issue Jul 8, 2017 · 9 comments
Closed

Node install destroyed PATH #14135

ofek opened this issue Jul 8, 2017 · 9 comments
Labels
install Issues and PRs related to the installers. npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.

Comments

@ofek
Copy link

ofek commented Jul 8, 2017

Version: v8.1.3
Platform: 64-bit Windows 7
Installer: https://nodejs.org/dist/v8.1.3/node-v8.1.3-x64.msi

I installed the current version of node/npm (8.1.3) from the site on Windows 7 and it removed everything in my user PATH except for C:\Users\Ofek\AppData\Roaming\npm. There's really not much else to say other than that I'm extremely upset :(

@ofek
Copy link
Author

ofek commented Jul 8, 2017

I just did a Windows system restore that reverted the Node install yesterday and now PATH is back. This definitely was caused by the installer.

@vsemozhetbyt vsemozhetbyt added install Issues and PRs related to the installers. npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform. labels Jul 8, 2017
@krydos
Copy link
Contributor

krydos commented Jul 8, 2017

Hey,
Is it possible for you to provide us with your current (non-broken) PATH value? Maybe there is something that can help us to understand the issue.

@gireeshpunathil
Copy link
Member

I tried installing the same node version on the same windows version and did not find anything wrong.
May be worth running with debug logger on to see if it reveals anything strange:
msiexec.exe /i <installer.msi> /L*V foo.log

@benjamingr
Copy link
Member

@nodejs/platform-windows

@tniessen
Copy link
Member

tniessen commented Jul 9, 2017

This is the WXS code we use to set the path for NPM:

<Environment Id="EnvironmentPathNpmModules"
             Action="set"
             Name="PATH"
             Part="last"
             System="no"
             Value="[AppDataFolder]npm"/>

There is not much room for a bug here, unless it is caused by WiX or Windows.

I setup a virtual machine (Windows 8.1) and set your exact PATH, but was unable to reproduce the issue.

@seishun
Copy link
Contributor

seishun commented Jul 9, 2017

@ofek can you reproduce it again?

@tniessen
Copy link
Member

tniessen commented Jul 9, 2017

@ofek Which node version was installed before, if any? Did you attempt to upgrade or install a new version?

Please try to reproduce the issue if you can. If you need assistence making a copy of your environment so you can restore it if things go wrong, let me know.

@refack
Copy link
Contributor

refack commented Jul 9, 2017

There is not much room for a bug here, unless it is caused by WiX or Windows.

That's not improbable.

@ofek
Copy link
Author

ofek commented Jul 9, 2017

I am extremely sorry everyone. The issue is mislav/hub#1506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install Issues and PRs related to the installers. npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

8 participants