Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failures in inspector/test-stop-profile-after-done - AIX #14897

Closed
mhdawson opened this issue Aug 17, 2017 · 7 comments
Closed

Intermittent failures in inspector/test-stop-profile-after-done - AIX #14897

mhdawson opened this issue Aug 17, 2017 · 7 comments
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol

Comments

@mhdawson
Copy link
Member

  • Version: master
  • Platform: AIX
  • Subsystem: inspector

I've seen a number of failures similar to this one in the last couple of days:

https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/7974/console

not ok 1599 inspector/test-stop-profile-after-done
  ---
  duration_ms: 0.700
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:57510/cab7755e-cc02-44f3-bba2-8a7772c5bfc7
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    { Error: connect ECONNREFUSED 127.0.0.1:57510
        at Object._errnoException (util.js:1038:11)
        at _exceptionWithHostPort (util.js:1061:20)
        at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1154:14)
      code: 'ECONNREFUSED',
      errno: 'ECONNREFUSED',
      syscall: 'connect',
      address: '127.0.0.1',
      port: 57510 }
    1
  ...
@mhdawson
Copy link
Member Author

mhdawson commented Aug 17, 2017

I see from the history that the test was re-written and the change committed a few days ago:

#14797

Fyi @eugeneo

@mhdawson
Copy link
Member Author

Stress test to see if it can be reproduced in a number of runs: https://ci.nodejs.org/job/node-stress-single-test/1376/

@addaleax addaleax added aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol labels Aug 17, 2017
@eugeneo
Copy link
Contributor

eugeneo commented Aug 17, 2017

I have a PR to mark it as flaky - #14874 - it is on the 48 hour cooldown, as per comitter guidelines.

It also fails on Windows, albeit differently.

@mhdawson
Copy link
Member Author

Thanks for taking action quickly. I'd added another approval to the PR and I don't think we necessarily need to wait for the 48 hours so I started a CI run.

@Trott
Copy link
Member

Trott commented Aug 19, 2017

Is this something anyone is actively working on?

@Trott
Copy link
Member

Trott commented Aug 22, 2017

@nodejs/v8-inspector @nodejs/platform-aix Any chance we have a volunteer to dig more deeply into this? It's a pretty frequent occurrence right now.

@jBarz
Copy link
Contributor

jBarz commented Oct 10, 2017

I have submitted a potential fix. #15774

cjihrig pushed a commit to cjihrig/node that referenced this issue Nov 6, 2017
Pause child on startup using inspect-brk=0 until the parent debugger
is ready.

PR-URL: nodejs#15774
Fixes: nodejs#14897
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this issue Nov 14, 2017
Pause child on startup using inspect-brk=0 until the parent debugger
is ready.

PR-URL: #15774
Fixes: #14897
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

5 participants