-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: rephrase documentation for child_process.execSync() #14944
Labels
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
Comments
mscdex
added
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
labels
Aug 19, 2017
I'd tweak the last part as well: ...
throw an [`Error`][] that will include the full result of the underlying
[`spawnSync()`][].
...
<!-- link definition in the footer -->
[`spawnSync()`]: #child_process_child_process_execsync_command_options |
refack
added
the
good first issue
Issues that are suitable for first-time contributors.
label
Aug 19, 2017
/cc @nodejs/documentation |
Both suggested changes sound reasonable. |
I'd like to pick this up! |
@ayazhafiz yours. (marked issue as |
refack
added
wip
Issues and PRs that are still a work in progress.
and removed
good first issue
Issues that are suitable for first-time contributors.
labels
Aug 20, 2017
ayazhafiz
added a commit
to ayazhafiz/node
that referenced
this issue
Aug 20, 2017
Rephrases the error thrown by child_process.execSync(). Fixes: nodejs#14944
3 tasks
ayazhafiz
added a commit
to ayazhafiz/node
that referenced
this issue
Aug 20, 2017
addaleax
pushed a commit
to addaleax/ayo
that referenced
this issue
Aug 25, 2017
Rephrases the error thrown by child_process.execSync(). PR-URL: nodejs/node#14953 Fixes: nodejs/node#14944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this issue
Aug 28, 2017
Rephrases the error thrown by child_process.execSync(). PR-URL: nodejs/node#14953 Fixes: nodejs/node#14944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
child_process
Issues and PRs related to the child_process subsystem.
doc
Issues and PRs related to the documentations.
The line at the end describing about the error thrown can be worded better.
Should be something like:
https://nodejs.org/api/child_process.html#child_process_child_process_execsync_command_options
[refack adding]
node/doc/api/child_process.md
Lines 687 to 689 in 467385a
The text was updated successfully, but these errors were encountered: