Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepping into function crashes debugger #15075

Closed
oliversalzburg opened this issue Aug 29, 2017 · 8 comments
Closed

Stepping into function crashes debugger #15075

oliversalzburg opened this issue Aug 29, 2017 · 8 comments
Labels
confirmed-bug Issues with confirmed bugs.

Comments

@oliversalzburg
Copy link
Contributor

oliversalzburg commented Aug 29, 2017

  • Version: 6.11.2
  • Platform: Windows x64
  • Subsystem: Debugger

Given is the following code:

"use strict"

function main(input) {
  const a = arg => {
    const b = input.find(e => e === arg);
  }
}

main([]);

Assume a setup like this (example uses VS Code):

image

When I hit the breakpoint on line 9 and step into, the debugger crashes 100% of the time.

From what I observe, the issue is specific to the instruction pointer resting on the fat-arrow expression. If a different expression is placed on line 4, the debugger will exit as soon as I step over it.

@benjamingr benjamingr added confirmed-bug Issues with confirmed bugs. debugger labels Aug 29, 2017
@benjamingr
Copy link
Member

Reproduced with v8.4.0 on macOS. Pinging @nodejs/v8-inspector

@targos
Copy link
Member

targos commented Aug 29, 2017

I can reproduce on Linux with v6.11.2 but not with v8.4.0.

@eugeneo
Copy link
Contributor

eugeneo commented Aug 29, 2017

I can't reproduce on Linux with 8.4 or top of tree, will try Mac later in the day.

@eugeneo
Copy link
Contributor

eugeneo commented Aug 30, 2017

Crash log:

Fatal error in ../deps/v8/src/debug/debug-scopes.cc, line 277

Check failed: nested_scope_chain_.length() == 1.

==== C stack trace ===============================

1: V8_Fatal
2: v8::internal::ScopeIterator::ScopeObject()
3: v8::internal::ScopeIterator::MaterializeScopeDetails()
4: 0x1a3e78e
5: v8::internal::Runtime_GetAllScopesDetails(int, v8::internal::Object**, v8::internal::Isolate*)
6: 0x19cb8aa060c7
Illegal instruction (core dumped)

CC:@ak239

@keangkai
Copy link

keangkai commented Sep 2, 2017

I think sysmbol or versions old because I'm same you

@hashseed
Copy link
Member

hashseed commented Sep 6, 2017

This is likely fixed by v8/v8@62b6dd1

@hashseed
Copy link
Member

hashseed commented Sep 6, 2017

Actually it was fixed by v8/v8@071b655 more than a year ago.

MylesBorins pushed a commit that referenced this issue Sep 19, 2017
Original commit message:

    [PATCH] [debugger] Scope iterator should not visit inner function literals.

    R=marja@chromium.org
    BUG=chromium:621361

    Review-Url: https://codereview.chromium.org/2185913003
    Cr-Commit-Position: refs/heads/master@{#38087}

Fixes: #15075

PR-URL: #15215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos
Copy link
Member

targos commented Sep 19, 2017

Fixed in 921876d

@targos targos closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

No branches or pull requests

6 participants