-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepping into function crashes debugger #15075
Comments
Reproduced with v8.4.0 on macOS. Pinging @nodejs/v8-inspector |
I can reproduce on Linux with v6.11.2 but not with v8.4.0. |
I can't reproduce on Linux with 8.4 or top of tree, will try Mac later in the day. |
Crash log: Fatal error in ../deps/v8/src/debug/debug-scopes.cc, line 277Check failed: nested_scope_chain_.length() == 1.==== C stack trace =============================== 1: V8_Fatal CC:@ak239 |
I think sysmbol or versions old because I'm same you |
This is likely fixed by v8/v8@62b6dd1 |
Actually it was fixed by v8/v8@071b655 more than a year ago. |
Original commit message: [PATCH] [debugger] Scope iterator should not visit inner function literals. R=marja@chromium.org BUG=chromium:621361 Review-Url: https://codereview.chromium.org/2185913003 Cr-Commit-Position: refs/heads/master@{#38087} Fixes: #15075 PR-URL: #15215 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fixed in 921876d |
Given is the following code:
Assume a setup like this (example uses VS Code):
When I hit the breakpoint on line 9 and step into, the debugger crashes 100% of the time.
From what I observe, the issue is specific to the instruction pointer resting on the fat-arrow expression. If a different expression is placed on line 4, the debugger will exit as soon as I step over it.
The text was updated successfully, but these errors were encountered: