-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
need libuv patch to build on current Android releases #15117
Labels
libuv
Issues and PRs related to the libuv dependency or the uv binding.
Comments
@DanAlbert (the Android NDK maintainer) asked me to check whether node.js builds out of the box with the current NDK. |
That commit has been released in libuv and will be in Node's next libuv update, which is already underway. |
mscdex
added
the
libuv
Issues and PRs related to the libuv dependency or the uv binding.
label
Aug 31, 2017
I'll close this out, will be fixed after the next libuv upgrade. |
cjihrig
added a commit
to cjihrig/node
that referenced
this issue
Sep 6, 2017
Fixes: nodejs#12737 Fixes: nodejs#13581 Fixes: nodejs#15117 PR-URL: nodejs#14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Sep 10, 2017
MylesBorins
pushed a commit
that referenced
this issue
Sep 11, 2017
MylesBorins
pushed a commit
that referenced
this issue
Sep 12, 2017
addaleax
pushed a commit
to addaleax/node
that referenced
this issue
Sep 13, 2017
Fixes: nodejs#12737 Fixes: nodejs#13581 Fixes: nodejs#15117 PR-URL: nodejs#14866 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Oct 16, 2017
MylesBorins
pushed a commit
that referenced
this issue
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
current Android releases have pthread_barrier_t, so the v8.4.0 build breaks:
you either need to upgrade libuv or at least cherrypick this commit: libuv/libuv@7dabd57
(hopefully i've reported this in time to be fixed in time for this October's LTS release; obviously the current LTS release has this problem, as does the "current" 8.4.0 release.)
The text was updated successfully, but these errors were encountered: