http2 - modifying compat req pseudo headers

[ronag]

When modifying a compat request headers some properties that depend on pseudo headers stop working. I'm not sure if this would count as compat breaking?

e.g.

removeAllHeaders(req)
assert(req.url) // uhoh? This worked before http/2

@apapirovski

[apapirovski]

Thanks for the report @ronag! It looks like we might need to specifically protect url & method.

[apapirovski]

After thinking about this a bit longer, I'm not this can be protected in a way that's satisfactory. In h2, url & method are both a part of the headers unlike in http1. While the goal is to be as compatible with the http1 API as possible, I think there are going to be areas where the differences will come through a little bit. If someone is deleting all headers then that's probably outside of our control.

@mcollina Any thoughts? As I see this, :path and :method can't just be taken out of the headers object and we can't maintain a reasonable link between a protected value & the value within the headers object.

[mcollina]

IMHO this needs to be documented, we cannot do much about it.
Would you like to send a PR?

cc @jasnell.

[jasnell]

Yeah, I agree. Protecting those headers is certainly possible but not without a significant cost to performance that just would not be worth it. Documenting would be best.