deprecate IncomingMessage 'aborted' event

[ronag]

The aborted event on IncomingMessage seems to do the exact same thing as the close event. I suggest that aborted is deprecated for reduced complexity and ambiguousness.

[jasnell]

ping @nodejs/http

[ronag]

At this point I think it would be enough to just remove it from the documentation but leave it in the code for backwards compat.

[lpinca]

I agree, it seems redundant but I think it doesn't cost us anything to maintain 1 line of code and 1 line of documentation.

[ronag]

@lpinca: Other than users trying to figure out when to use what when reading the docs.

[lpinca]

@ronag is it confusing for you? If so can you please explain why?
I find it normal to be emitted before 'close' but we can make it explicit in the docs.

[ronag]

@lpinca: It adds a layer of complexity. It's already confusing in general when and what events will be emitted and in what order. Currently, I and my teammates have to read the node code for every event to try and understand how they work. The fewer events there are the easier it is.

Having two events doing the same thing is weird and I've been trying to figure out the difference... which I assumed existed but it turns out it wasn't there.

[ronag]

I've been trying to put a little effort into figuring out and making the whole event behavior easier:

#15469
#15456
#15387
#15361
#15360
#15318
#15317
#15303
#15259

[apapirovski]

There has been no movement and we're unlikely to get rid of it as things stand. I'm going to close this for now but maybe we'll revisit at some point in the future if http gets a bit more attention.