-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems building 8.6.0 on OpenBSD -current #15784
Comments
How did you download the source and how did you invoke configure and make? The missing references are from Lines 2172 to 2185 in b48ff2a
Sanity check: does ./configure -- -DOS=openbsd && make -j8 work?
|
git clone git@github.com:nodejs/node.git
cd node
git checkout v8.6.0
./configure --prefix=$HOME
make -j4
After I applied #10904 (comment) and ran
|
Maybe try removing the |
Same. |
Same with |
Same with |
Works with |
Quick check: what happens when you revert bfb97b7? |
Builds. |
Okay thanks, good to know. I don't see any glaring bugs in that commit, you may have to do some digging. |
@adriangrigore I'm closing this out. Please leave a comment if there is anything to report. |
@bnoordhuis There is a bug in there: bfb97b7#diff-f3cd2c1f9253f4c4c618eae60dc6d644R2180 |
stack_trace_posix to 'sources' as well. Fixes nodejs#15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources
R=machenbach@chromium.org Fixes nodejs/node#15784 Change-Id: I4453023a5a6c8ace45b898ea227870fb6cbc20b2 Reviewed-on: https://chromium-review.googlesource.com/893261 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51017}
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes nodejs#15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: nodejs#18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes nodejs#15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: nodejs#18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add stack_trace_posix to 'sources' as well. Fixes nodejs#15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: nodejs#18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
I applied this patch #10904 (comment).
The text was updated successfully, but these errors were encountered: