Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/function_call does not work with the benchmark suite #16154

Closed
joyeecheung opened this issue Oct 12, 2017 · 1 comment
Closed

misc/function_call does not work with the benchmark suite #16154

joyeecheung opened this issue Oct 12, 2017 · 1 comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Oct 12, 2017

  • Version: master
  • Subsystem: benchmark

This benchmark requires running make in the directory to build the addon before it can be run (also the Makefile tries to use the global node-gyp, not the one in the codebase). Currently running it with run.js it will just report misc/function_call.js Binding failed to load.

Should we keep this benchmark? If so, it needs to be fixed to work with our current benchmark suite. The purpose of this benchmark seems to be:

// show the difference between calling a short js function
// relative to a comparable C++ function.
// Reports millions of calls per second.
// Note that JS speed goes up, while cxx speed stays about the same.

sounds useful to me.

@joyeecheung joyeecheung added the benchmark Issues and PRs related to the benchmark subsystem. label Oct 12, 2017
@bnoordhuis
Copy link
Member

I think you are supposed to invoke the benchmarks through make bench or make bench-misc, that will build the add-on. There is probably room for improvement, though.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 12, 2017
Move the logic for building the benchmark/misc/function_call to
the top-level Makefile and use our local copy of node-gyp.

Fixes: nodejs#16154
addaleax pushed a commit to ayojs/ayo that referenced this issue Oct 15, 2017
Move the logic for building the benchmark/misc/function_call to
the top-level Makefile and use our local copy of node-gyp.

PR-URL: nodejs/node#16160
Fixes: nodejs/node#16154
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos pushed a commit that referenced this issue Oct 18, 2017
Move the logic for building the benchmark/misc/function_call to
the top-level Makefile and use our local copy of node-gyp.

PR-URL: #16160
Fixes: #16154
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

No branches or pull requests

2 participants