Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 8.6 assumes llvm on FreeBSD #16257

Closed
chmeeedalf opened this issue Oct 17, 2017 · 3 comments
Closed

node 8.6 assumes llvm on FreeBSD #16257

chmeeedalf opened this issue Oct 17, 2017 · 3 comments
Labels
build Issues and PRs related to build files or the CI. freebsd Issues and PRs related to the FreeBSD platform.

Comments

@chmeeedalf
Copy link

When building node 8.6 for PowerPC (uses gcc, not clang), I see the following error:

gyp: name 'llvm_version' is not defined while evaluating condition 'llvm_version
< "4.0"' in /wrkdirs/usr/ports/www/node/work/node-v8.6.0/node.gyp while trying
to load /wrkdirs/usr/ports/www/node/work/node-v8.6.0/node.gyp
creating ./icu_config.gypi

This appears to have been introduced by Pull Request #14077 .
@mscdex mscdex added build Issues and PRs related to build files or the CI. freebsd Issues and PRs related to the FreeBSD platform. labels Oct 17, 2017
@bnoordhuis
Copy link
Member

A pull request would be welcome.

@mmarchini mmarchini mentioned this issue Nov 4, 2017
Closed
2 tasks
mmarchini pushed a commit to mmarchini/node that referenced this issue Nov 27, 2017
build: fix bsd build with gcc
62d7469 
BSD build with GCC was broken because it was checking for the llvm_version
variable on common.gypi, even though llvm wasn't installed (or needed). If
LLVM wasn't installed, llvm_version wasn't being defined, breaking the build.

Fixes: nodejs#16257
@refack refack closed this as completed in 4a7487b Nov 27, 2017
@chmeeedalf
Copy link
Author

Thanks!

MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@MylesBorins
build: fix bsd build with gcc
304dfab 
BSD build with GCC was broken because it was checking for the
llvm_version variable on common.gypi, even though llvm wasn't
installed (or needed).

PR-URL: #16737
Fixes: #16257
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@MylesBorins
build: fix bsd build with gcc
61a6a25 
BSD build with GCC was broken because it was checking for the
llvm_version variable on common.gypi, even though llvm wasn't
installed (or needed).

PR-URL: #16737
Fixes: #16257
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
@MylesBorins
build: fix bsd build with gcc
0a40a11 
BSD build with GCC was broken because it was checking for the
llvm_version variable on common.gypi, even though llvm wasn't
installed (or needed).

PR-URL: #16737
Fixes: #16257
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
gibfahn pushed a commit that referenced this issue Dec 19, 2017
@gibfahn
build: fix bsd build with gcc
986e439 
BSD build with GCC was broken because it was checking for the
llvm_version variable on common.gypi, even though llvm wasn't
installed (or needed).

PR-URL: #16737
Fixes: #16257
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
@gibfahn
build: fix bsd build with gcc
134bbd8 
BSD build with GCC was broken because it was checking for the
llvm_version variable on common.gypi, even though llvm wasn't
installed (or needed).

PR-URL: #16737
Fixes: #16257
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jmarceli
Copy link

Sorry for commenting on such an old thread, but just to clarify I would mention that the solution for FreeBSD is using Node version at least 8.9.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. freebsd Issues and PRs related to the FreeBSD platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix bsd build with gcc mmarchini/node
4 participants
@mscdex @bnoordhuis @chmeeedalf @jmarceli