-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No DNS Search Domain support in C-Ares calls #17850
Comments
This is about node.js not honoring the
|
@bnoordhuis I see, good to know. Thanks for the quick answer. The situation we encountered at my company is that we use a VPN to connect to our Kubernetes cluster. Services can have multiple instances and use DNS hostnames to load balance to one or the other (through KubeDNS). We also put these hostnames behind subdomains of one of our domains so that even development services benefit of our TLS certificate. Since the hostnames are a bit long outside of the Kubernetes internal network, we let the VPN access the Kuberenetes DNS resolver to allow for short-hand service hostnames usage on our development machines. @bcorijn Correct me if I'm wrong? Not the most common use case of course, more of a convenience thing. So I understand if this isn't a priority. It did take us a bit of time to understand why certain apps were affected or not because some DNS resolutions used |
Hi, If this issue is still open I can take it. |
@Manicqin You mean adding a |
lib: dns.js - passing the search field form the options object to QueryReqWrap object. src: base_object.h - added GetField function to read fields from the persistent object (persistent QueryReqWrap object). cares_wrap.cc - added a AresSearch function. - QueryAWrap (resolve4) and QueryAaaaWrap (resolve6) utilizes the AresSearch when options.search is true. doc/api: added search option to the resolve4 and resolve6 documentation Fixes: nodejs#17850
@Manicqin will you be able to resolve this issue or can I take up this issue? |
@bnoordhuis Can I work on this issue? |
Sure. The other pull request looks to have stalled. |
@bnoordhuis took a shot in #22226 , based on your review suggestions in #19548 . complete noob at C++, though, so might require a bit of handholding. Also, need guidance in writing tests. |
Should this remain open? |
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment. For more information on how the project manages feature requests, please consult the feature request management document. |
There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment. For more information on how the project manages feature requests, please consult the feature request management document. |
It would seem that currently, Node.js calls through the C-Ares DNS resolver (
resolve4()
andresolve6()
) don't support search domains.Is this a bug? If not, are there current or planned configuration options to specify them?
Should this issue be cross-posted to the C-Ares repository?
To make reproduction of this issue easier, I created a Docker-based repository that you can find here:
https://github.com/Mickael-van-der-Beek/node-dns-test
PS: Be careful to not use Alpine Linux as Docker based image due to
muslc
being used and notglibc
. I will create a ticket about this in their repository later.EDIT: Might be related to this issue that was supposedly fixed in the past: #9799
The text was updated successfully, but these errors were encountered: