Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: URLTest.ToFilePath from cctest\test_url.cc fails when --without-intl flag used #19051

Closed
vsemozhetbyt opened this issue Feb 28, 2018 · 3 comments
Closed

test: URLTest.ToFilePath from cctest\test_url.cc fails when --without-intl flag used #19051

vsemozhetbyt opened this issue Feb 28, 2018 · 3 comments
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests.

Comments

@vsemozhetbyt
Copy link
Contributor

  • Version: master (10.0.0)
  • Platform: Windows 7 x64
  • Subsystem: test

From the output of .\vcbuild without-intl test:

[ RUN      ] URLTest.ToFilePath
test\cctest\test_url.cc(91): error: Value of: URL("file://xn--weird-prdj8vva.com/host/a").ToFilePath()
  Actual: "\\\\xn--weird-prdj8vva.com\\host\\a"
Expected: "\\\\wͪ͊eiͬ͋rd.com\\host\\a"
Which is: "\\\\w\xCD\xAA\xCD\x8A" "ei\xCD\xAC\xCD\x8Brd.com\\host\\a"
[  FAILED  ] URLTest.ToFilePath (0 ms)
[----------] 7 tests from URLTest (31 ms total)

[----------] Global test environment tear-down
[==========] 41 tests from 6 test cases ran. (250 ms total)
[  PASSED  ] 40 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] URLTest.ToFilePath

 1 FAILED TEST

Should it be skipped in such case?
@vsemozhetbyt vsemozhetbyt added c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests. i18n-api Issues and PRs related to the i18n implementation. labels Feb 28, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Feb 28, 2018 •
edited
Loading

cc @nodejs/testing, @bmeck

@TimothyGu
Copy link
Member

@vsemozhetbyt I wrote that test even though the blame points to @bmeck.

Should it be skipped in such case?

Yes.

@vsemozhetbyt
Copy link
Contributor Author

cc @nodejs/testing . Sorry, I do not know C++(

@jasnell jasnell mentioned this issue Aug 11, 2018
Closed
3 tasks
jasnell added a commit to jasnell/node that referenced this issue Aug 16, 2018
@jasnell
test: fix cctest URLTest.ToFilePath on Win32 without Intl
a86a5f6 
Skip one specific test that requires ICU

Fixes: nodejs#19051
targos pushed a commit that referenced this issue Aug 19, 2018
@jasnell @targos
test: fix cctest URLTest.ToFilePath on Win32 without Intl
e515ce0 
Skip one specific test that requires ICU

Fixes: #19051

PR-URL: #22265
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this issue Sep 3, 2018
@jasnell @targos
test: fix cctest URLTest.ToFilePath on Win32 without Intl
44bcc1d 
Skip one specific test that requires ICU

Fixes: #19051

PR-URL: #22265
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimothyGu @vsemozhetbyt