Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominate @trivikr #19067

Closed
mcollina opened this issue Mar 1, 2018 · 13 comments
Closed

Nominate @trivikr #19067

mcollina opened this issue Mar 1, 2018 · 13 comments
Labels
tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Comments

@mcollina
Copy link
Member

mcollina commented Mar 1, 2018 •
edited
Loading

I'd like to nominate @trivikr as a collaborator, for his work on http2. This is long overdue!

Commits in the nodejs/node repository

Comments and reviews on issues.
@BridgeAR
Copy link
Member

BridgeAR commented Mar 1, 2018

+1

1 similar comment
@gireeshpunathil
Copy link
Member

+1

@trivikr
Copy link
Member

trivikr commented Mar 1, 2018

Thank you @mcollina for nominating me for NodeJS Collaborator!
It's a big responsibility - I'll try my best to continue contributing to NodeJS and get others onboard 😄

@mmarchini
Copy link
Contributor

+1

@jasnell
Copy link
Member

jasnell commented Mar 1, 2018

+1 💯

@mhdawson
Copy link
Member

mhdawson commented Mar 1, 2018

+1

1 similar comment
@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

+1

@mcollina mcollina added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 8, 2018
@mcollina
Copy link
Member Author

mcollina commented Mar 8, 2018

Added tsc-agenda to announce it in the next meeeting cc @nodejs/tsc

@mhdawson mhdawson mentioned this issue Mar 12, 2018
Closed
@MylesBorins
Copy link
Contributor

+1

@Fishrock123
Copy link
Contributor

Wait, why is this on the agenda?

@mcollina
Copy link
Member Author

mcollina commented Mar 14, 2018 via email

@Fishrock123
Copy link
Contributor

Fishrock123 commented Mar 14, 2018 •
edited
Loading

We do? Since when? It's only just been github issues up until now.

@mcollina
Copy link
Member Author

@Fishrock123 #18268.

trivikr added a commit to trivikr/node that referenced this issue Mar 17, 2018
@trivikr
doc: add trivikr to collaborators
e6a3436 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: nodejs#19067
@trivikr trivikr mentioned this issue Mar 17, 2018
Closed
2 tasks
@mhdawson mhdawson mentioned this issue Mar 19, 2018
Closed
@trivikr trivikr mentioned this issue Mar 20, 2018
Closed
2 tasks
trivikr added a commit that referenced this issue Mar 20, 2018
@trivikr
doc: add trivikr to collaborators
6a958d2 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: #19067

PR-URL: #19384
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@trivikr trivikr closed this as completed Mar 21, 2018
MylesBorins pushed a commit that referenced this issue Mar 22, 2018
@trivikr @MylesBorins
doc: add trivikr to collaborators
9c9263e 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: #19067

PR-URL: #19384
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins pushed a commit that referenced this issue Aug 17, 2018
@trivikr @MylesBorins
doc: add trivikr to collaborators
ab559b8 
trivikr is nominated as node core collaborator for his work on http2
https://github.com/nodejs/node/commits?author=trivikr

Refs: #19067

PR-URL: #19384
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@mcollina @jasnell @MylesBorins @Fishrock123 @mmarchini @gireeshpunathil @BridgeAR @mhdawson @gibfahn @trivikr