investigate flaky sequential/test-inspector-stop-profile-after-done #19263

Trott · 2018-03-09T17:46:01Z

Version: 10.0.0-pre (master)
Platform: win2016 vs2017
Subsystem: inspector test

https://ci.nodejs.org/job/node-test-binary-windows/15597/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console

not ok 535 sequential/test-inspector-stop-profile-after-done
  ---
  duration_ms: 6.574
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:55287/eddeff2f-6cfe-4edd-8a6d-d17133dee77a
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [err] Debugger attached.
    [err] Waiting for the debugger to disconnect...
    [err] 
    { AssertionError [ERR_ASSERTION]: 0 strictEqual 3221225477
        at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-stop-profile-after-done.js:28:10)
        at process._tickCallback (internal/process/next_tick.js:114:7)
      generatedMessage: true,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 0,
      expected: 3221225477,
      operator: 'strictEqual' }
    1
  ...

Anyone know what exit code 3221225477 means on Windows? ("actual" and "expected" are reversed above. I'll submit a PR to fix the test.)

@nodejs/platform-windows @nodejs/testing @nodejs/v8-inspector

Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: nodejs#19263

richardlau · 2018-03-09T18:16:31Z

Anyone know what exit code 3221225477 means on Windows?

3221225477 is 0xC0000005 which is STATUS_ACCESS_VIOLATION. Something is attempting to access memory it shouldn't be.

Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

bzoz · 2018-03-12T16:56:14Z

There is a stress test for this test with this setup from 6 days ago: https://ci.nodejs.org/job/node-stress-single-test/1786/, the test passed. It also does not reproduce on my win10 box.

Possible it was just some random fluke of the CI?

bzoz · 2018-03-13T07:15:26Z

Nevermind, just saw it failing again: https://ci.nodejs.org/job/node-test-binary-windows/15664/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=3/console

bzoz · 2018-03-13T15:41:48Z

I've made a stress-test run and it passed: https://ci.nodejs.org/job/node-stress-single-test/1790/, I can't also reproduce this on my win2016 vm.

Trott · 2018-03-13T16:04:51Z

Might be a hardware or other problem with a specific host.

https://ci.nodejs.org/job/node-test-binary-windows/15664/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=3/console is a failure on test-azure_msft-win2016-x64-1.

https://ci.nodejs.org/job/node-test-binary-windows/15597/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console is also a failure on test-azure_msft-win2016-x64-1.

The successful stress tests are both on test-azure_msft-win2016-x64-6.

Trott · 2018-03-13T16:08:55Z

I'd like to test the host-specific theory with stress tests, but they don't seem to pick up test-azure_msft-win2016-x64-1. Kicking off multiple stress tests engages test-azure_msft-win2016-x64-6 on the first one and all the others just wait even though test-azure_msft-win2016-x64-1 is idle. Am I doing something wrong? @nodejs/build

Stress test on test-azure_msft-win2016-x64-6 (should pass if theory is correct): https://ci.nodejs.org/job/node-stress-single-test/1791/

Trott · 2018-03-13T17:47:39Z

Yet another failure and again it's on test-azure_msft-win2016-x64-1: https://ci.nodejs.org/job/node-test-binary-windows/15679/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/console

I'm really starting to think that specific host is the problem.

Trott · 2018-03-14T13:40:22Z

Yet another one on test-azure_msft-win2016-x64-1: https://ci.nodejs.org/job/node-test-binary-windows/15694/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console

This really does seem like there's something wrong with test-azure_msft-win2016-x64-1 specifically. @nodejs/build

Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

MylesBorins · 2018-03-18T20:43:48Z

Another one --> https://ci.nodejs.org/job/node-test-binary-windows/15732/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/console

Trott · 2018-03-18T21:11:38Z

Once again, the failure is on test-azure_msft-win2016-x64-1 and not some other host in the rotation. Is there someone on @nodejs/build that can poke around on that particular host to see if something is up? Or maybe destroy it and rebuild it in the hopes that it fixes whatever is up?

Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Trott · 2018-03-20T13:29:49Z

Happened again and once again it is on test-azure_msft-win2016-x64-1 and not on one of the other machines.

https://ci.nodejs.org/job/node-test-binary-windows/15811/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console

not ok 537 sequential/test-inspector-stop-profile-after-done
  ---
  duration_ms: 1.255
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:59700/ac9aacff-b053-4716-8167-2eaf9740e69f
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [err] Debugger attached.
    [err] Waiting for the debugger to disconnect...
    [err] 
    { AssertionError [ERR_ASSERTION]: 3221225477 strictEqual 0
        at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-stop-profile-after-done.js:28:10)
        at process._tickCallback (internal/process/next_tick.js:114:7)
      generatedMessage: true,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 3221225477,
      expected: 0,
      operator: 'strictEqual' }
    1

richardlau · 2018-03-21T18:31:40Z

Another failure on test-azure_msft-win2016-x64-1:
https://ci.nodejs.org/job/node-test-binary-windows/15756/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console

joaocgreis · 2018-03-22T15:07:51Z

I marked the machine offline in CI while I investigate. If I can't find the cause, I'll rebuild the machine.

Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: nodejs#19263 PR-URL: nodejs#19264 Refs: nodejs#19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: #19263 PR-URL: #19264 Refs: #19263 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Trott added windows Issues and PRs related to the Windows platform. inspector Issues and PRs related to the V8 inspector protocol flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Mar 9, 2018

Trott added a commit to Trott/io.js that referenced this issue Mar 9, 2018

test: fix assertion argument order

3841636

Fix the assertion argument order so that it will report "actual" and "expected" correctly when the test fails. Ref: nodejs#19263

Trott mentioned this issue Mar 9, 2018

test: fix assertion argument order #19264

Closed

2 tasks

Trott mentioned this issue Mar 13, 2018

crypto: ECDH convertKey to convert public keys between different formats #19080

Closed

4 tasks

MylesBorins mentioned this issue Mar 18, 2018

deps: patch V8 to 6.5.254.40 #19380

Closed

richardlau mentioned this issue Mar 21, 2018

cluster: Add support to cluster to work with `NODE_OPTIONS="--inspect" #19165

Closed

Trott closed this as completed Jun 3, 2018

bzoz mentioned this issue Jun 14, 2018

Investigate flaky test-inspector-stop-profile-after-done on Windows #21233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

investigate flaky sequential/test-inspector-stop-profile-after-done #19263

investigate flaky sequential/test-inspector-stop-profile-after-done #19263

Trott commented Mar 9, 2018

richardlau commented Mar 9, 2018

bzoz commented Mar 12, 2018

bzoz commented Mar 13, 2018

bzoz commented Mar 13, 2018

Trott commented Mar 13, 2018

Trott commented Mar 13, 2018

Trott commented Mar 13, 2018

Trott commented Mar 14, 2018

MylesBorins commented Mar 18, 2018

Trott commented Mar 18, 2018

Trott commented Mar 20, 2018

richardlau commented Mar 21, 2018

joaocgreis commented Mar 22, 2018

investigate flaky sequential/test-inspector-stop-profile-after-done #19263

investigate flaky sequential/test-inspector-stop-profile-after-done #19263

Comments

Trott commented Mar 9, 2018

richardlau commented Mar 9, 2018

bzoz commented Mar 12, 2018

bzoz commented Mar 13, 2018

bzoz commented Mar 13, 2018

Trott commented Mar 13, 2018

Trott commented Mar 13, 2018

Trott commented Mar 13, 2018

Trott commented Mar 14, 2018

MylesBorins commented Mar 18, 2018

Trott commented Mar 18, 2018

Trott commented Mar 20, 2018

richardlau commented Mar 21, 2018

joaocgreis commented Mar 22, 2018