Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test process.setuid for bad argument types #19591

Closed
dsinecos opened this issue Mar 25, 2018 · 1 comment
Closed

test: Test process.setuid for bad argument types #19591

dsinecos opened this issue Mar 25, 2018 · 1 comment

Comments

@dsinecos
Copy link
Contributor

  • Version: master
  • Platform: 16.04.1, Ubuntu
  • Subsystem: test

While reading through the tests I found that there is a test for bad argument types for process.seteuid but there isn't a corresponding test ( process.setuid({}) ) for bad argument types for process.setuid

I think that a corresponding test could be added in the file to test bad argument types for process.setuid as well.

If this makes sense, I'd like to contribute through a PR on this.
@gireeshpunathil
Copy link
Member

@dsinecos - go for it!

dsinecos added a commit to dsinecos/node that referenced this issue Mar 30, 2018
@dsinecos
test: test process.setuid for bad argument types
6bf36f0 
test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid

Fixes: nodejs#19591
@dsinecos dsinecos mentioned this issue Mar 30, 2018
Closed
2 tasks
@lpinca lpinca closed this as completed in 83444b7 Apr 4, 2018
targos pushed a commit that referenced this issue Apr 4, 2018
@dsinecos @targos
test: test process.setuid for bad argument types
92e9ed0 
Test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid.

PR-URL: #19703
Fixes: #19591
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 4, 2018
@dsinecos @BethGriggs
test: test process.setuid for bad argument types
5e09a3d 
Test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid.

PR-URL: #19703
Fixes: #19591
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: test process.setuid for bad argument types dsinecos/node
2 participants
@gireeshpunathil @dsinecos