Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation around contributing #20

Closed
MauriceButler opened this issue Dec 2, 2014 · 5 comments
Closed

Confirmation around contributing #20

MauriceButler opened this issue Dec 2, 2014 · 5 comments

Comments

@MauriceButler
Copy link
Contributor

Hi guys,

Just want to confirm the status of contributions as all docs still link to the joyent contribution guidelines.

I have already jumped through those hoops but moving forward, and for others that have not, should they?

@rvagg mentioned in #3 that things are still being finalised and to expect more information this week.

Should we hold off committing to this repo till things are finalised or go forth and pull request?

@indutny
Copy link
Member

indutny commented Dec 2, 2014

@MauriceButler Hello,

Please do commit! Regardless of all politics and expected information, your contribution will be very valuable for both joyent/node and iojs/io.js . There is no limiting force that could prevent us or original repo from merging each other's commits.

Cheers,
Fedor.

@MauriceButler
Copy link
Contributor Author

Thanks for the confirmation @indutny

@rvagg
Copy link
Member

rvagg commented Dec 2, 2014

👍 one goal here is to ease the friction of contribution and enable greater discussion around technical stuff, the more PRs to discuss the better!

@brendanashworth
Copy link
Contributor

Vote to close? This seems resolved.

@indutny
Copy link
Member

indutny commented Dec 17, 2014

Guess so.

@indutny indutny closed this as completed Dec 17, 2014
dacappo added a commit to SAP-archive/node-rasp that referenced this issue Nov 29, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
dacappo added a commit to SAP-archive/node-rasp that referenced this issue Dec 3, 2018
dacappo added a commit to SAP-archive/node-rasp that referenced this issue Jan 24, 2019
flakey5 added a commit to flakey5/node that referenced this issue Dec 17, 2022
* Almost finish up blob work

* Finish some todos in DataQueue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants