We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OutgoingMessage doesn't always emit 'close' after emitting 'finish'.
'use strict'; const common = require('../common'); const http = require('http'); const server = http.Server(common.mustCall((req, res) => { res.end(); res.on('finish', common.mustCall()); res.on('close', common.mustCall()); req.on('close', common.mustCall()); res.socket.on('close', () => server.close()); })); server.listen(0, common.mustCall(() => { http.get({ port: server.address().port }, common.mustCall()); }));
The text was updated successfully, but these errors were encountered:
f22c7c1
http: always emit close on req and res
8029a24
PR-URL: #20611 Fixes: #20600 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add test of http streams
e63da58
This broke in Node.js 10.2.0 because of: nodejs/node#20611 Node core issue: nodejs/node#20600 Node core fix: nodejs/node#20611
Successfully merging a pull request may close this issue.
OutgoingMessage doesn't always emit 'close' after emitting 'finish'.
The text was updated successfully, but these errors were encountered: