Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util.types.isBigInt64Array and util.types.isBigUint64Array are in Node 10 but undocumented. #20602

Closed
jdalton opened this issue May 8, 2018 · 2 comments
Closed

util.types.isBigInt64Array and util.types.isBigUint64Array are in Node 10 but undocumented. #20602

jdalton opened this issue May 8, 2018 · 2 comments

Comments

@jdalton
Copy link
Member

jdalton commented May 8, 2018 •
edited
Loading

util.types.isBigInt64Array and util.types.isBigUint64Array are in Node 10,
but are undocumented.

Related to #20016.
@targos
Copy link
Member

targos commented May 8, 2018

Are they available without the --harmony-bigint flag?

@jdalton
Copy link
Member Author

jdalton commented May 8, 2018

Are they available without the --harmony-bigint flag?

Yes, I believe there are no flags set in my setup.

@cjihrig cjihrig mentioned this issue May 9, 2018
Merged
3 tasks
cjihrig added a commit to cjihrig/node that referenced this issue May 9, 2018
@cjihrig
doc: add util.types.isBig{Int,Uint}64Array()
2246c3c 
These methods are exposed, even though the BigInt64Array and
BigUint64Array types are currently behind the --harmony-bigint
command line flag.

PR-URL: nodejs#20615
Fixes: nodejs#20602
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this issue May 12, 2018
@cjihrig @targos
doc: add util.types.isBig{Int,Uint}64Array()
c546746 
These methods are exposed, even though the BigInt64Array and
BigUint64Array types are currently behind the --harmony-bigint
command line flag.

PR-URL: #20615
Fixes: #20602
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @targos