Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menacing thread safety comment in node_crypto.cc #21488

Closed
TimothyGu opened this issue Jun 23, 2018 · 1 comment
Closed

Menacing thread safety comment in node_crypto.cc #21488

TimothyGu opened this issue Jun 23, 2018 · 1 comment
Labels
crypto Issues and PRs related to the crypto subsystem. worker Issues and PRs related to Worker support.

Comments

@TimothyGu
Copy link
Member

node/src/node_crypto.cc

Lines 2157 to 2160 in a40e062

// XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe
// in the presence of invalid error codes. Probably academical but something
// to keep in mind if/when node ever grows multi-isolate capabilities.
const char* reason = X509_verify_cert_error_string(x509_verify_error);

Now that we have workers, the scenario described in the comment is here. Do we need to do anything about it? Or can we just change the comment to a simple note rather a XXX?

/cc @addaleax @bnoordhuis

@TimothyGu TimothyGu added crypto Issues and PRs related to the crypto subsystem. worker Issues and PRs related to Worker support. labels Jun 23, 2018
@bnoordhuis
Copy link
Member

This was actually fixed in openssl/openssl@c0a445a9f27. The comment is obsolete and can be removed.

TimothyGu added a commit to TimothyGu/node that referenced this issue Jun 24, 2018
targos pushed a commit that referenced this issue Jun 25, 2018
PR-URL: #21511
Fixes: #21488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants