Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 bug fixes for s390x #22364

Closed
john-yan opened this issue Aug 16, 2018 · 2 comments
Closed

v8 bug fixes for s390x #22364

john-yan opened this issue Aug 16, 2018 · 2 comments

Comments

@john-yan
Copy link

Please backport https://chromium-review.googlesource.com/c/v8/v8/+/1176424 to fix high 32 bit corruption issue which leading to seg fault crash in v8 on this test case:

simpleRandomString = function (size) {
  let ret = '';
  const ids = 'abcdefghijkmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';    // <- this fails on Z
  for (let i = 0; i < size; i++) {
      let rand = Math.random ();
      console.log ('1 rand', rand);
      let numb = rand * ids.length;
      console.log ('2 numb', numb);
      let pos = Math.floor (numb);
      console.log ('3 pos', pos, typeof pos, ids.length);
      let id = ids[pos];        // <- RANDOM seg faults here
      console.log ('4 id', id);
      ret += id;
      console.log ('5 ret', ret);
    }
  return ret;
};

for (let i = 100000; i >= 0; i--) {                             // loop de loop
    let rand = simpleRandomString (2);  // call the troublesome function
    console.log ('iters left', i, ' word:', rand, '\n');
}

console.log ('success');

@john-yan
Copy link
Author

Create PR: #22375

@gdams
Copy link
Member

gdams commented Aug 26, 2018

This got landed in: 5294919. Closing

@gdams gdams closed this as completed Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants