Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make -jN warning: jobserver unavailable #22457

Closed
targos opened this issue Aug 22, 2018 · 4 comments
Closed

make -jN warning: jobserver unavailable #22457

targos opened this issue Aug 22, 2018 · 4 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@targos
Copy link
Member

targos commented Aug 22, 2018

When compiling on the master branch, I have the following warning:

$ make -j8 V=
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
...

Is this a problem?

git bisect points to the following commit 4e2fa8b (@danbev):

4e2fa8b0dc1acd95f558cd5f123711b9cc936c72 is the first bad commit
commit 4e2fa8b0dc1acd95f558cd5f123711b9cc936c72
Author: Daniel Bevenius <daniel.bevenius@gmail.com>
Date:   Tue Aug 14 09:46:11 2018 +0200

    build: extract common code from NODE_EXE/_G_EXE
    
    This commit extracts common parts of the NODE_EXE, and NODE_G_EXE
    recipes into a canned reciepe to reduce some code duplication.
    
    PR-URL: https://github.com/nodejs/node/pull/22310
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>

:100644 100644 3ca83bfed85ead088bd66568556d543c6a8d4602 f3372b096316af704589f6eae7ac3adbb9fec3c4 M	Makefile
@targos targos added the build Issues and PRs related to build files or the CI. label Aug 22, 2018
@targos
Copy link
Member Author

targos commented Aug 22, 2018

Extracted from the make documentation:

In order for make processes to communicate, the parent will pass information to the child. Since this could result in problems if the child process isn’t actually a make, the parent will only do this if it thinks the child is a make. The parent uses the normal algorithms to determine this (see How the MAKE Variable Works). If the makefile is constructed such that the parent doesn’t know the child is a make process, then the child will receive only part of the information necessary. In this case, the child will generate this warning message and proceed with its build in a sequential manner.

@danbev
Copy link
Contributor

danbev commented Aug 22, 2018

@targos I'll take a look at this hopefully later this afternoon or tomorrow morning.

danbev added a commit to danbev/node that referenced this issue Aug 22, 2018
@danbev
Copy link
Contributor

danbev commented Aug 22, 2018

@targos I don't get this warning locally and need to figure out what a change would look like but think reverting is the best option since the build time is affected. Thanks for bringing this to my attention!

refack pushed a commit that referenced this issue Aug 22, 2018
This reverts commit 4e2fa8b.

Refs: #22457

PR-URL: #22458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack
Copy link
Contributor

refack commented Aug 22, 2018

Fixed by: #22458

@refack refack closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

3 participants