-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some test errors from an Ubuntu 14.04 64bit machine #2255
Comments
I'm pretty sure that'd be from using ecryptfs which has absurd path length limitations and causes these kinds of problems. |
Ah, yes, looks like that was the issue. Thanks. |
@Fishrock123 @aks- Try building Node in @rvagg Does Node really need so long path names to run correctly? So far the only indication that I have absurd path length limitations on my file system was Node's |
@rsp context for that test is here: #1991 — I'd be open to supporting a PR that can make it optionally run in environments where it can't run, like ecryptfs, but I'm not really sure how or even if that can be achieved. The long pathname issue is what made me stop using ecryptfs and go with full disk encryption on Linux instead. It bit me with more than just Node. |
@rvagg I prepared a PR #3925 that fixes this issue. It changes only those two tests that fail on ecryptfs file systems (test-fs-long-path.js and test-require-long-path.js) so that they make their files under /tmp - actually, os.tmpdir() - but only on Linux and only when it verifies that it can create a directory there. Otherwise (i.e. not on Linux or if it can't create directory in /tmp) it works the same as before my changes. If you think it is not how it should work and it should try to create files under /tmp only when the current tests fails, please let me know so I prepare a new PR. Thanks. I think this fix is important because even though it is not Node's fault that ecryptfs has those limitations, the fact is that people still use ecryptfs on default installs of Ubuntu and for them it looks like Node is broken, not ecryptfs. I actually found this issue when someone told me that he can't compile Node because tests fail and refused to |
@Fishrock123 I think the |
If not running on Windows it skips the long path tests in: * test-fs-long-path.js * test-require-long-path.js Fixes: nodejs#2255 PR-URL: nodejs#4116 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
I'm helping @aks- get started to contributing to node; he reported these errors to me on IRC from his Ubuntu 14.04-64bit machine, which I haven't seen reported before.
(dunno who to cc)
The text was updated successfully, but these errors were encountered: