Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running configure twice will most likely cause test failures #23352

Closed
danbev opened this issue Oct 9, 2018 · 3 comments · Fixed by #23355
Closed

Running configure twice will most likely cause test failures #23352

danbev opened this issue Oct 9, 2018 · 3 comments · Fixed by #23355
Labels
build Issues and PRs related to build files or the CI. regression Issues related to regressions.

Comments

@danbev
Copy link
Contributor

danbev commented Oct 9, 2018 •
edited
Loading

  • Version: v11.0.0-pre
  • Platform: Darwin MacBook-Pro-3.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64
  • Subsystem: build

Currently when running configure without any options and running the test suite will pass successfully. If one the runs configure again but this time with an option, for example --debug-nghttp2 the will be test failures. The same goes for other options like --without-ssl.

I think this might be related to 6dd4a07. I've reverted this locally to test and that does resolve the issue but wanted to see if this could perhaps be fixed without reverting first.
@Trott
Copy link
Member

Trott commented Oct 9, 2018

/ping @refack

@refack refack mentioned this issue Oct 9, 2018
Merged
2 tasks
@refack refack added build Issues and PRs related to build files or the CI. regression Issues related to regressions. labels Oct 9, 2018
@refack
Copy link
Contributor

refack commented Oct 9, 2018

@danbev can you check if #23355 fixes that.

@danbev
Copy link
Contributor Author

danbev commented Oct 10, 2018

@danbev can you check if #23355 fixes that.

It fixes this issue, thanks for that!

refack added a commit to refack/node that referenced this issue Oct 10, 2018
@refack
build: restore js2c direct dependency on config.gypi
484e4db 
PR-URL: nodejs#23355
Fixes: nodejs#23352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this issue Oct 10, 2018
@refack @targos
build: restore js2c direct dependency on config.gypi
e6484c2 
PR-URL: #23355
Fixes: #23352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit that referenced this issue Oct 17, 2018
@refack @jasnell
build: restore js2c direct dependency on config.gypi
ec3740c 
PR-URL: #23355
Fixes: #23352
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. regression Issues related to regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: restore js2c direct dependency on config.gypi refack/node
3 participants
@refack @danbev @Trott