Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Readme #2361

Closed
jasnell opened this issue Aug 12, 2015 · 5 comments
Closed

Update the Readme #2361

jasnell opened this issue Aug 12, 2015 · 5 comments
Labels
doc Issues and PRs related to the documentations.
Milestone
4.0.0

Comments

@jasnell
Copy link
Member

jasnell commented Aug 12, 2015

Obviously, the project README.md needs to be updated now 👍 Can we go ahead and get things renamed?
@mscdex mscdex added the doc Issues and PRs related to the documentations. label Aug 12, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Aug 12, 2015

@jasnell I'm working on his.

@cjihrig
Copy link
Contributor

cjihrig commented Aug 12, 2015

Question - do we want to update the references to io.js within code? Seems that it would be more correct, but I know extra noise in code is frowned upon.

@jasnell
Copy link
Member Author

jasnell commented Aug 12, 2015

In general, it would likely be a good idea. Rip the bandaid off all at one so to speak.

@Fishrock123
Copy link
Contributor

👍 On master. :)

@brendanashworth brendanashworth added this to the 4.0.0 milestone Aug 14, 2015
cjihrig added a commit to cjihrig/node that referenced this issue Aug 23, 2015
@cjihrig
node: rename from io.js to node
1b7162a 
This commit replaces instances of io.js with Node.js, based on the
recent convergence. There are some remaining instances of io.js,
related to build and the installer.

Fixes: nodejs#2361
PR-URL: nodejs#2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
cjihrig added a commit to cjihrig/node that referenced this issue Aug 23, 2015
@cjihrig
process: make process.release.name "node"
ff6e1b7 
This commit sets the value of process.release.name to "node".

Fixes: nodejs#2361
PR-URL: nodejs#2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
cjihrig added a commit to cjihrig/node that referenced this issue Aug 23, 2015
@cjihrig
node: additional cleanup for node rename
2308a52 
Fixes: nodejs#2361
PR-URL: nodejs#2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
cjihrig added a commit that referenced this issue Aug 23, 2015
@cjihrig
node: rename from io.js to node
a69ab27 
This commit replaces instances of io.js with Node.js, based on the
recent convergence. There are some remaining instances of io.js,
related to build and the installer.

Fixes: #2361
PR-URL: #2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
cjihrig added a commit that referenced this issue Aug 23, 2015
@cjihrig
process: make process.release.name "node"
4f50d3f 
This commit sets the value of process.release.name to "node".

Fixes: #2361
PR-URL: #2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
cjihrig added a commit that referenced this issue Aug 23, 2015
@cjihrig
node: additional cleanup for node rename
3b60252 
Fixes: #2361
PR-URL: #2367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@cjihrig
Copy link
Contributor

cjihrig commented Aug 23, 2015

Fixed in a69ab27, 45a2046, 4f50d3f, and 3b60252.

@cjihrig cjihrig closed this as completed Aug 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
5 participants
@mscdex @jasnell @Fishrock123 @cjihrig @brendanashworth