-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for Http2ServerRequest properties #23825
Comments
@nodejs/documentation @nodejs/http2 |
Looks like |
@Trott Point me in the right direct and I'd take this on asap. |
@kenigbolo I think the documentation of And the contributing guide for PRs is a good starting point. But for a "documentation only" PR there is no need to compile and test node itself. It should be enough to test the documentation with And if |
@mgjm Thanks a lot. I'd get on it today. Can this be assigned to me? |
Add documentation for http2 request `authority` and `scheme` psuedo headers of http2 request
This pull request covers adding documentation for authority and scheme Fixes: nodejs#23825
This pull request adds the request psuedo headers authority and scheme to the http2 documentation Fixes: nodejs#23825
This pull request adds the request psuedo headers authority and scheme to the http2 documentation PR-URL: nodejs#24777 Fixes: nodejs#23825 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Is your feature request related to a problem? Please describe.
The
http2.Http2ServerRequest
has some useful properties that are undocumented. But IMHO, they should be part of the public API.Describe the solution you'd like
The following properties could become part of the
http2
module documentation:method
,authority
,scheme
,url
(See
lib/internal/http2/compat.js
)Describe alternatives you've considered
The alternative is to use the headers object:
PR?
If these properties should be documented and therefore part of the public API, I am happy to create the corresponding documentation in a PR.
The text was updated successfully, but these errors were encountered: