Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check minimum ICU version for system-icu #24253

Closed
srl295 opened this issue Nov 8, 2018 · 1 comment
Closed

check minimum ICU version for system-icu #24253

srl295 opened this issue Nov 8, 2018 · 1 comment
Assignees
@srl295
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Nov 8, 2018

  • Platform: all
  • Subsystem: deps

See https://crbug.com/v8/8401

Need to check that the system ICU meets minimum requirements.

Missed this with #19657
@srl295
Copy link
Member Author

srl295 commented Nov 8, 2018

also note that with the crbug above, ICU version 63 will be required and need to be bumped in tools/icu/icu_versions.json (from 57 to 63)…

This was referenced Nov 8, 2018
Merged
Closed
@srl295 srl295 self-assigned this Nov 8, 2018
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Nov 8, 2018
refack pushed a commit to srl295/node that referenced this issue Nov 17, 2018
@srl295 @refack
build: check minimum ICU in configure for system-icu
ed1c40e 
- check the version number coming out of pkg-config

PR-URL: nodejs#24255
Fixes: nodejs#24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Nov 18, 2018
@srl295 @targos
build: check minimum ICU in configure for system-icu
c63243e 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@srl295 @rvagg
build: check minimum ICU in configure for system-icu
4dc1e78 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Jan 12, 2019
@srl295 @codebytere
build: check minimum ICU in configure for system-icu
c0f0d19 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this issue Jan 29, 2019
@srl295 @codebytere
build: check minimum ICU in configure for system-icu
5d2dadc 
- check the version number coming out of pkg-config

PR-URL: #24255
Fixes: #24253
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srl295