Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test test-cluster-worker-forced-exit #2557

Closed
joaocgreis opened this issue Aug 26, 2015 · 3 comments
Closed

Investigate flaky test test-cluster-worker-forced-exit #2557

joaocgreis opened this issue Aug 26, 2015 · 3 comments
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Comments

@joaocgreis
Copy link
Member

Examples of failures:
@joaocgreis joaocgreis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Aug 26, 2015
@brendanashworth brendanashworth added the arm Issues and PRs related to the ARM platform. label Aug 26, 2015
@Trott Trott mentioned this issue Nov 23, 2015
Closed
@Trott
Copy link
Member

Trott commented Nov 23, 2015

Running this test 9999 times on armv7-wheezy results in no failures:
https://ci.nodejs.org/job/node-stress-single-test/28/nodes=armv7-wheezy/console

I propose removing its flaky designation in #3975

If/when it fails again, we can always add it back.

Otherwise, maybe something changed in the code or in CI that fixed the issue?

@rvagg
Copy link
Member

rvagg commented Nov 23, 2015

we did do an upgrade of the slaves on armv7-wheezy at some point, probably between the OP and now, +1 to removing flaky, can you take care of that @Trott?

@Trott
Copy link
Member

Trott commented Nov 23, 2015

@rvagg: Yup. #3975

Trott added a commit to Trott/io.js that referenced this issue Nov 24, 2015
@Trott
test: remove flaky status for cluster test
0ff1ba4 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: nodejs#2557
@Trott Trott closed this as completed in 6588422 Nov 24, 2015
Trott added a commit that referenced this issue Dec 1, 2015
@Trott
test: remove flaky status for cluster test
45e27d1 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this issue Dec 4, 2015
@Trott @rvagg
test: remove flaky status for cluster test
950af45 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this issue Dec 5, 2015
@Trott @rvagg
test: remove flaky status for cluster test
a863e8d 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this issue Dec 17, 2015
@Trott @jasnell
test: remove flaky status for cluster test
b2f1014 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this issue Dec 23, 2015
@Trott @jasnell
test: remove flaky status for cluster test
eb95182 
The test did not fail after 9999 runs in continuous integration.

Remove it's flaky status.

Fixes: #2557
PR-URL: #3975
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@mhdawson mhdawson mentioned this issue Jan 18, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joaocgreis @rvagg @Trott @brendanashworth