test-worker-uncaught-exception-async - flaky on Windows? #25702
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
windows
Issues and PRs related to the Windows platform.
worker
Issues and PRs related to Worker support.
Comments
7 tasks
addaleax
added
flaky-test
|
unable to repro in 3K runs (win 10, I don't have a win 2008). Better wait to see if it occurs again. |
addaleax
added a commit
to addaleax/node
that referenced
this issue
Feb 3, 2019
The Windows ETW code is not written to be compatible with multi-threading, and in particular it relies on global state like a single static `uv_async_t`. Adding that to multiple threads would corrupt the corresponding loops' handle queues. This addresses the flakiness of at least `test-worker-exit-code` and very likely other flaky tests that relate to Worker threads on Windows as well. Fixes: nodejs#25847 Fixes: nodejs#25702 Fixes: nodejs#24005 Fixes: nodejs#23873
2 tasks
addaleax
added a commit
that referenced
this issue
Feb 6, 2019
The Windows ETW code is not written to be compatible with multi threading, and in particular it relies on global state like a single static `uv_async_t`. Adding that to multiple threads would corrupt the corresponding loops' handle queues. This addresses the flakiness of at least `test-worker-exit-code` and very likely other flaky tests that relate to Worker threads on Windows as well. Fixes: #25847 Fixes: #25702 Fixes: #24005 Fixes: #23873 PR-URL: #25907 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Failure in unrelated PR
https://ci.nodejs.org/job/node-test-binary-windows/23291/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console
18:04:17 not ok 542 parallel/test-worker-uncaught-exception-async 18:04:17 --- 18:04:17 duration_ms: 120.75 18:04:17 severity: fail 18:04:17 exitcode: 1 18:04:17 stack: |- 18:04:17 timeout 18:04:17 foo 18:04:17 ...The text was updated successfully, but these errors were encountered: