Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-https-connect-localport #26862

Closed
joyeecheung opened this issue Mar 22, 2019 · 4 comments
Closed

Investigate flaky parallel/test-https-connect-localport #26862

joyeecheung opened this issue Mar 22, 2019 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Mar 22, 2019 •
edited
Loading

Refs: nodejs/reliability#21

Reason parallel/test-https-connect-localport
Type JS_TEST_FAILURE
Failed PR 4 (#26810, #26738, #26760, #26802)
Appeared test-osuosl-ubuntu1404-ppc64_le-1, test-osuosl-ubuntu1404-ppc64_le-2, test-packetnet-centos7-arm64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/21713/
Last CI https://ci.nodejs.org/job/node-test-pull-request/21769/
Example 
not ok 1129 parallel/test-https-connect-localport
  ---
  duration_ms: 0.171
  severity: fail
  exitcode: 1
  stack: |-
    (node:7223) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
    events.js:170
          throw er; // Unhandled 'error' event
          ^
    
    Error: bind EADDRINUSE 0.0.0.0:34567
        at internalConnect (net.js:806:18)
        at defaultTriggerAsyncIdScope (internal/async_hooks.js:297:19)
        at net.js:930:9
        at processTicksAndRejections (internal/process/task_queues.js:79:9)
        at process.runNextTicks [as _tickCallback] (internal/process/task_queues.js:56:3)
        at Function.Module.runMain (internal/modules/cjs/loader.js:880:11)
        at internal/main/run_main_module.js:21:11
    Emitted 'error' event at:
        at TLSSocket.socketErrorListener (_http_client.js:401:9)
        at TLSSocket.emit (events.js:193:13)
        at emitErrorNT (internal/streams/destroy.j...
@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 22, 2019 •
edited
Loading

Judging from the first CI this appeared, this might be related to #26209

cc @sam-github ?

@joyeecheung joyeecheung added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Mar 22, 2019
@joyeecheung joyeecheung mentioned this issue Mar 22, 2019
Closed
@Trott
Copy link
Member

Trott commented Mar 23, 2019

https://ci.nodejs.org/job/node-test-commit-plinux/24626/nodes=ppcle-ubuntu1404/console

test-osuosl-ubuntu1404-ppc64_le-1

00:04:14 not ok 1129 parallel/test-https-connect-localport
00:04:14   ---
00:04:14   duration_ms: 0.185
00:04:14   severity: fail
00:04:14   exitcode: 1
00:04:14   stack: |-
00:04:14     (node:21338) [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
00:04:14     events.js:171
00:04:14           throw er; // Unhandled 'error' event
00:04:14           ^
00:04:14     
00:04:14     Error: bind EADDRINUSE 0.0.0.0:34567
00:04:14         at internalConnect (net.js:806:18)
00:04:14         at defaultTriggerAsyncIdScope (internal/async_hooks.js:298:19)
00:04:14         at net.js:930:9
00:04:14         at processTicksAndRejections (internal/process/task_queues.js:79:9)
00:04:14         at process.runNextTicks [as _tickCallback] (internal/process/task_queues.js:56:3)
00:04:14         at Function.Module.runMain (internal/modules/cjs/loader.js:880:11)
00:04:14         at internal/main/run_main_module.js:21:11
00:04:14     Emitted 'error' event at:
00:04:14         at TLSSocket.socketErrorListener (_http_client.js:401:9)
00:04:14         at TLSSocket.emit (events.js:194:13)
00:04:14         at emitErrorNT (internal/streams/destroy.js:91:8)
00:04:14         at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
00:04:14         at processTicksAndRejections (internal/process/task_queues.js:81:17)
00:04:14         at process.runNextTicks [as _tickCallback] (internal/process/task_queues.js:56:3)
00:04:14         at Function.Module.runMain (internal/modules/cjs/loader.js:880:11)
00:04:14         at internal/main/run_main_module.js:21:11
00:04:14   ...

@Trott
Copy link
Member

Trott commented Mar 23, 2019

The problem is that the test has a hard-coded port which no test in parallel should have since it will sometimes conflict with other tests in parallel that ask the OS for an unspecified available port. I'll open a PR to fix....

Trott added a commit to Trott/io.js that referenced this issue Mar 23, 2019
@Trott
test: move test-https-connect-localport to sequential
dad3deb 
test-https-connect-localport uses a hard-coded port number. Therefore
the test cannot be in the parallel directory because it will sometimes
conflict with other tests that run at the same time and request that the
OS provide an available port.

Fixes: nodejs#26862
@Trott
Copy link
Member

Trott commented Mar 23, 2019

PR to fix: #26881

Trott added a commit to Trott/io.js that referenced this issue Mar 24, 2019
@Trott
test: use common.PORT instead of hardcoded number
229759f 
In sequential/test-https-connect-localport, replace 34567 with
common.PORT.

PR-URL: nodejs#26881
Fixes: nodejs#26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Mar 24, 2019
@Trott
test: replace localhost IP with 'localhost' for TLS conformity
f5969f0 
test-https-connect-localport currently causes a runtime deprecation
warning: "[DEP0123] DeprecationWarning: Setting the TLS ServerName
to an IP address is not permitted by RFC 6066. This will be ignored
in a future version."

Change IP usage to the string 'localhost' instead.

PR-URL: nodejs#26881
Fixes: nodejs#26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Mar 24, 2019
@Trott
test: refactor test-https-connect-localport
4a40ea6 
Use arrow functions for callbacks. Replace uses of `this` with explicit
variables. Add a trailing comma in a multiline object literal
declaration.

PR-URL: nodejs#26881
Fixes: nodejs#26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@Trott Trott closed this as completed in 0f7e24a Mar 24, 2019
targos pushed a commit to targos/node that referenced this issue Mar 27, 2019
@Trott @targos
test: move test-https-connect-localport to sequential
0470dc6 
test-https-connect-localport uses a hard-coded port number. Therefore
the test cannot be in the parallel directory because it will sometimes
conflict with other tests that run at the same time and request that the
OS provide an available port.

Fixes: nodejs#26862

PR-URL: nodejs#26881
Fixes: nodejs#26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit to targos/node that referenced this issue Mar 27, 2019
@Trott @targos
test: use common.PORT instead of hardcoded number
4fbec0c 
In sequential/test-https-connect-localport, replace 34567 with
common.PORT.

PR-URL: nodejs#26881
Fixes: nodejs#26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit to targos/node that referenced this issue Mar 27, 2019
@Trott @targos
test: replace localhost IP with 'localhost' for TLS conformity
547d01d 
test-https-connect-localport currently causes a runtime deprecation
warning: "[DEP0123] DeprecationWarning: Setting the TLS ServerName
to an IP address is not permitted by RFC 6066. This will be ignored
in a future version."

Change IP usage to the string 'localhost' instead.

PR-URL: nodejs#26881
Fixes: nodejs#26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit to targos/node that referenced this issue Mar 27, 2019
@Trott @targos
test: refactor test-https-connect-localport
544253d 
Use arrow functions for callbacks. Replace uses of `this` with explicit
variables. Add a trailing comma in a multiline object literal
declaration.

PR-URL: nodejs#26881
Fixes: nodejs#26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this issue Mar 27, 2019
@Trott @targos
test: move test-https-connect-localport to sequential
4919e4b 
test-https-connect-localport uses a hard-coded port number. Therefore
the test cannot be in the parallel directory because it will sometimes
conflict with other tests that run at the same time and request that the
OS provide an available port.

Fixes: #26862

PR-URL: #26881
Fixes: #26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this issue Mar 27, 2019
@Trott @targos
test: use common.PORT instead of hardcoded number
011c205 
In sequential/test-https-connect-localport, replace 34567 with
common.PORT.

PR-URL: #26881
Fixes: #26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this issue Mar 27, 2019
@Trott @targos
test: replace localhost IP with 'localhost' for TLS conformity
838fb95 
test-https-connect-localport currently causes a runtime deprecation
warning: "[DEP0123] DeprecationWarning: Setting the TLS ServerName
to an IP address is not permitted by RFC 6066. This will be ignored
in a future version."

Change IP usage to the string 'localhost' instead.

PR-URL: #26881
Fixes: #26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
targos pushed a commit that referenced this issue Mar 27, 2019
@Trott @targos
test: refactor test-https-connect-localport
3cae010 
Use arrow functions for callbacks. Replace uses of `this` with explicit
variables. Add a trailing comma in a multiline object literal
declaration.

PR-URL: #26881
Fixes: #26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @joyeecheung