IncomingMessage and OutgoingMessage's destroy ignores the second argument callback, swallowing the error

[zen0wu]

• Version: 12.4.0
• Platform: Mac OS
• Subsystem:

Use case: Treat a streaming HTTP response as an AsyncIterable and iterate through to do some processing.

1. When an error happens in the async iterable stream processing,
2. The error is propagated to the underlying stream with a callback to be triggered the rejection of the promise: https://github.com/nodejs/node/blob/49f1bb9b93/lib/internal/streams/async_iterator.js#L118
3. When the underlying stream is IncomingMessage (in my case, or OutgoingMessage), destroy don't even take the callback, hence ignoring the error: https://github.com/nodejs/node/blob/49f1bb9b93/lib/_http_incoming.js#L102

[ronag]

This looks like a bug. We should use finished instead of the extra callback variant of destroy.

[ronag]

I believe this was fixed in: #31316

[jasnell]

Closing. We can reopen if it turns out that #31316 did not fix it