Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We could use your help improving Node.js' Windows testing #29852

Closed
1 of 7 tasks
bcoe opened this issue Oct 5, 2019 · 8 comments
Closed
1 of 7 tasks

We could use your help improving Node.js' Windows testing #29852

bcoe opened this issue Oct 5, 2019 · 8 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. windows Issues and PRs related to the Windows platform.

Comments

@bcoe
Copy link
Contributor

bcoe commented Oct 5, 2019

  • Version: head
  • Platform: Windows
  • Subsystem: test

I've been noticing windows tests flapping more than usual for the past few days:

https://ci.nodejs.org/job/node-test-binary-windows-2/3344/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/

https://ci.nodejs.org/job/node-test-binary-windows-2/3341/

We could use some help digging into this, it would be a great first contribution.


Known issues

If you're working on a specific issue, chime in on this thread and create an issue referencing it.

  • test/parallel/test-child-process-fork-exec-path:
    Error: ENOTEMPTY: directory not empty, rmdir 'c:\workspace\node-test-binary-windows- 
     2\test\.tmp.124'
     at Object.rmdirSync (fs.js:779:3)
     at rmdirSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:86:10)
     at rimrafSync (c:\workspace\node-test-binary-windows-2\test\common\tmpdir.js:41:7)
  • test/parallel/test-http2-client-upload:
    events.js:187
          throw er; // Unhandled 'error' event
          ^
    Error: read ECONNRESET
        at TCP.onStreamRead (internal/stream_base_commons.js:201:27)
  • test/sequential/test-http2-large-file:
       events.js:187
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at TCP.onStreamRead (internal/stream_base_commons.js:201:27)
  • test/parallel/test-child-process-pipe-dataflow (see: flaky: test-child-process-pipe-dataflow #25988):
    assert.js:93
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: child 1 exited with code 1
        at ChildProcess.<anonymous> (c:\workspace\node-test-binary-windows-2\test\parallel\test- 
    child-process-pipe-dataflow.js:49:14)
    
  • parallel/test-http2-* (see: flaky: parallel/test-http2-* on Windows #20750).
  • test/async-hooks/test-statwatcher.
    fail (1)
    Stacktrace
    Watcher: w1
    current stat data: Stats {
      dev: 748388947,
      mode: 33206,
      nlink: 1,
      uid: 0,
      gid: 0,
      rdev: 0,
      blksize: 4096,
    
  • out of memory issues when spawning subprocesses (see: child_process: child_process.spawn ENOMEM on Windows  #25484, talk to @coreyfarrell for more details).

Getting Started

  1. read BUILDING.md for instructions on building for Windows.
  2. once you've built Node.js, you can run individual tests simply by invoking (./node test/parallel/test-xyz.js, where test-xyz.js is the test you wish to run).
  3. once you're making some progress on a bug comment on this thread, and it will help ensure that other folks don't take the same issue.
  4. recent Windows builds can be found here, if you want to dig further https://ci.nodejs.org/job/node-test-commit-windows-fanned/
@bcoe bcoe added flaky-test Issues and PRs related to the tests with unstable failures on the CI. Hacktoberfest help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Oct 5, 2019
@bcoe

This comment has been minimized.

@ganes1410
Copy link

@bcoe Can I look into this?

@bcoe

This comment has been minimized.

@richardlau

This comment has been minimized.

@bcoe bcoe added the windows Issues and PRs related to the Windows platform. label Oct 5, 2019
@bcoe
Copy link
Contributor Author

bcoe commented Oct 6, 2019

@ganes1410 👋 I've updated the original issue with more details about getting started.

@richardlau, I've added the issue you linked.

@bcoe bcoe changed the title Windows tests appear to be flapping on head We could use your help improving Node.js' Windows testing Oct 7, 2019
@ganes1410
Copy link

sure @bcoe. I have completed the initial setup. I'll let you know in this issue once I have some progress

@Trott
Copy link
Member

Trott commented Oct 9, 2019

@nodejs/platform-windows

lundibundi added a commit to lundibundi/node that referenced this issue Nov 17, 2019
This makes rmdirSync call itself after handling ENOTEMPTY, EEXIST, EPERM
errors instead of directly using fs.rmdirSync to handle the possibility
of such errors repeating on the next try (i.e. FS finished writing new
file just as we are done with our loop to delete all files).

Refs: nodejs#29852
BridgeAR pushed a commit that referenced this issue Dec 20, 2019
Wait for close event on server stream before shuting down server and
client to avoid races seen on windows CI.

Refs: #20750 (comment)

PR-URL: #29889
Refs: #29852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this issue Jan 3, 2020
Wait for close event on server stream before shuting down server and
client to avoid races seen on windows CI.

Refs: #20750 (comment)

PR-URL: #29889
Refs: #29852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Jan 14, 2020
Wait for close event on server stream before shuting down server and
client to avoid races seen on windows CI.

Refs: #20750 (comment)

PR-URL: #29889
Refs: #29852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
Wait for close event on server stream before shuting down server and
client to avoid races seen on windows CI.

Refs: #20750 (comment)

PR-URL: #29889
Refs: #29852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bcoe
Copy link
Contributor Author

bcoe commented Jan 18, 2021

I think this issue is likely a bit stale at this point, let's open a new one if we notice CI failures in Windows are again cropping up too frequently.

@bcoe bcoe closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants