-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We could use your help improving Node.js' Windows testing #29852
Comments
This comment has been minimized.
This comment has been minimized.
@bcoe Can I look into this? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ganes1410 👋 I've updated the original issue with more details about getting started. @richardlau, I've added the issue you linked. |
sure @bcoe. I have completed the initial setup. I'll let you know in this issue once I have some progress |
@nodejs/platform-windows |
This makes rmdirSync call itself after handling ENOTEMPTY, EEXIST, EPERM errors instead of directly using fs.rmdirSync to handle the possibility of such errors repeating on the next try (i.e. FS finished writing new file just as we are done with our loop to delete all files). Refs: nodejs#29852
Wait for close event on server stream before shuting down server and client to avoid races seen on windows CI. Refs: #20750 (comment) PR-URL: #29889 Refs: #29852 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Wait for close event on server stream before shuting down server and client to avoid races seen on windows CI. Refs: #20750 (comment) PR-URL: #29889 Refs: #29852 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Wait for close event on server stream before shuting down server and client to avoid races seen on windows CI. Refs: #20750 (comment) PR-URL: #29889 Refs: #29852 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Wait for close event on server stream before shuting down server and client to avoid races seen on windows CI. Refs: #20750 (comment) PR-URL: #29889 Refs: #29852 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
I think this issue is likely a bit stale at this point, let's open a new one if we notice CI failures in Windows are again cropping up too frequently. |
I've been noticing windows tests flapping more than usual for the past few days:
https://ci.nodejs.org/job/node-test-binary-windows-2/3344/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/
https://ci.nodejs.org/job/node-test-binary-windows-2/3341/
We could use some help digging into this, it would be a great first contribution.
Known issues
If you're working on a specific issue, chime in on this thread and create an issue referencing it.
test/parallel/test-child-process-fork-exec-path
:test/parallel/test-http2-client-upload
:test/sequential/test-http2-large-file
:test/parallel/test-child-process-pipe-dataflow
(see: flaky: test-child-process-pipe-dataflow #25988):parallel/test-http2-*
(see: flaky:parallel/test-http2-*
on Windows #20750).test/async-hooks/test-statwatcher
.Getting Started
./node test/parallel/test-xyz.js
, wheretest-xyz.js
is the test you wish to run).The text was updated successfully, but these errors were encountered: