Documentation for http.message.url suggests using deprecated url API

[denilsonsa]

At the following piece of documentation (for v12; the latest one):

• https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_message_url
• https://github.com/nodejs/node/blob/master/doc/api/http.md#messageurl

It describes:

To parse the url into its parts require('url').parse(request.url) can be used:
[…]
…or true can be passed as the second argument to require('url').parse:
[…]

However, this legacy url module/API is deprecated since v11.

Thus, the documentation should be updated.

Bonus points for grepping the rest of the documentation to find other outdated examples.

[lpinca]

The WHATWG URL API will not work in this case unless a bogus base URL is provided as second argument.

[saitolume]

@lpinca Can I work on this issue?
This is my first time contributing to Node.js

[lpinca]

Yes but again, there is no equivalent for WHATWG URL.

[saitolume]

Hmm… Should I remove deprecated docs or update with WHATWG URL to provide a bogus URL as second argument?

If the later, I will replace it like this:

> new URL('/status?name=ryan', 'https://nodejs.org')
URL {
  href: 'https://nodejs.org/status?name=ryan',
  origin: 'https://nodejs.org',
  protocol: 'https:',
  username: '',
  password: '',
  host: 'nodejs.org',
  hostname: 'nodejs.org',
  port: '',
  pathname: '/status',
  search: '?name=ryan',
  searchParams: URLSearchParams { 'name' => 'ryan' },
  hash: ''
}

[lpinca]

@nodejs/url

[dev-script]

@lpinca i would like to work on this issue.

[joyeecheung]

In the context of http.IncomingMessage, it might make sense to suggest something like

new URL(request.url, `http://${request.headers.host}`);

(or http:// can be replaced with a ${protocol}:// to be more generic. Of course this does not work if request.headers does not actually contain host but I guess in that case a 404 should already be sent anyway)

Then give some examples like the one in #30048 (comment)

[saitolume]

@joyeecheung Thank you for a good idea! I will try to refactor doc soon.