Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add NO_COLOR to disable colors in assert doc #30484

Closed
shobhitchittora opened this issue Nov 14, 2019 · 1 comment
Closed

doc: add NO_COLOR to disable colors in assert doc #30484

shobhitchittora opened this issue Nov 14, 2019 · 1 comment
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.

Comments

@shobhitchittora
Copy link
Contributor

shobhitchittora commented Nov 14, 2019 •
edited
Loading

Currently the assert docs point to only NODE_DISABLE_COLORS env variable to disable tty colors. NO_COLOR does the same thing.

Going ahead and creating a small PR to add the variable there.

  • Version: v12.8.0
  • Platform: Darwin Kernel Version 18.7.0
  • Subsystem: doc
@shobhitchittora shobhitchittora mentioned this issue Nov 14, 2019
Closed
4 tasks
@lpinca lpinca added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Nov 17, 2019
addaleax pushed a commit that referenced this issue Nov 18, 2019
@shobhitchittora @addaleax
doc: adds NO_COLOR to assert doc page
5bb4d85 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BridgeAR pushed a commit that referenced this issue Nov 19, 2019
@shobhitchittora @BridgeAR
doc: adds NO_COLOR to assert doc page
7f664e4 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
targos pushed a commit that referenced this issue Dec 1, 2019
@shobhitchittora @targos
doc: adds NO_COLOR to assert doc page
8bb232f 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@lpinca
Copy link
Member

lpinca commented Dec 7, 2019

Fixed by #30483.

@lpinca lpinca closed this as completed Dec 7, 2019
MylesBorins pushed a commit that referenced this issue Dec 17, 2019
@shobhitchittora @MylesBorins
doc: adds NO_COLOR to assert doc page
ec5fe99 
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

PR-URL: #30483
Refs: #30484
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpinca @shobhitchittora