Wrong async stack trace

[ZFail]

Version: v13.3.0
Platform: Windows 7x64 and Ununtu 18.04 Linux 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

This fragment of code:

const fs = require('fs')

async function bar() {
    // throw new Error('Good stack trace')
    try {
        await fs.promises.readFile('nonexistent-file')
    } catch (e) {
        throw new Error('Wrong stack trace')
    }
}

async function run() {
    await new Promise(resolve => setTimeout(resolve, 10))
    await bar()
}

run().then(() => console.log('success'), error => console.error(error))

generates wrong stack trace:

Error: Wrong stack trace
    at bar (D:\projects\test-exc\exc.js:8:15)

If we replace try-catch block with simple throw new Error('Good stack trace'), stack trace will be normal:

Error: Good stack trace
    at bar (D:\projects\test-exc\exc.js:4:11)
    at run (D:\projects\test-exc\exc.js:14:11)

[BridgeAR]

@nodejs/v8 this seems to an issue with V8 and I am able to reproduce it in the dev tools as well.

Simplified test case (without anything Node.js specific):

async function bar() {
    // throw new Error('Good stack trace')
    try {
        await Promise.reject(new Error('Good stack trace'))
    } catch (e) {
        console.log(e)
        throw new Error('Wrong stack trace')
    }
}

async function run() {
    await bar()
}

run().then(() => console.log('success'), error => console.error(error))

[ryzokuken]

@BridgeAR could you please file this issue upstream?

[verwaest]

Fixing this in https://chromium-review.googlesource.com/c/v8/v8/+/1969897

[BridgeAR]

@verwaest I also opened an issue for it on the V8 issue tracker a couple of days ago: https://bugs.chromium.org/p/v8/issues/detail?id=10040

[niyarlatotep]

@BridgeAR could you please have a look?
I have a similar problem, is it the same? Or is it a different problem?
Good stack trace (one iteration only):

(async function() {
    try {
        await foo();
    } catch (e) {
        console.error(e);
    }
})();

async function foo(){
    let exception;
    for (let i=0; i<1; i++){
        try {
            await Promise.reject(new Error('Good stack trace'));
        } catch (e) {
            exception = e;
        }
    }
    throw exception;
}

Bad stack trace (if two iterations and more):

(async function() {
    try {
        await foo();
    } catch (e) {
        console.error(e);
    }
})();

async function foo(){
    let exception;
    for (let i=0; i<=1; i++){
        try {
            await Promise.reject(new Error('Bad stack trace'));
        } catch (e) {
            exception = e;
        }
    }
    throw exception;
}

[verwaest]

That's basically the same. The first iteration (after my fix) you still get a complete stack trace because you're still executing synchronously when the error object is created. The await isn't executed yet. Any iteration after that now includes the first (anonymous) function, where it didn't before the fix.

[targos]

Fixed in V8.