-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpipe() and resume() in _transform() #31190
Comments
/cc @ronag |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ronag The only two things I could think of are a) process.exit() or equivalents being called or b) blocking JS execution that prevents the nextTick queue from running. For debugging Node.js core, it’s sometimes a good idea to use That being said, if I just add the |
Oh, thanks for that! I'll keep digging. |
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 Backport-PR-URL: nodejs#32264 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#32264
pipe() ondata should not control flow state if cleaned up. Fixes: #31190 Backport-PR-URL: #32264 PR-URL: #31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #32264
In case of synchronous pipe removal in _transform, the resume method does not resume as expected
Nevertheless, resume operation during an asynchronous call and removal not from the _transform method
Can someone explain this behavior why unpipe () and resume () do not work in the _transform method?
The text was updated successfully, but these errors were encountered: