Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider switching to Chromium's source-map implementation #31286

Closed
bcoe opened this issue Jan 9, 2020 · 0 comments
Closed

consider switching to Chromium's source-map implementation #31286

bcoe opened this issue Jan 9, 2020 · 0 comments
Labels
source maps Issues and PRs related to source map support.

Comments

@bcoe
Copy link
Contributor

bcoe commented Jan 9, 2020

Describe the solution you'd like

@joyeecheung points out in #31132 that we might do better to pull in Chromium's SourceMap implementation, which seems to have evolved beyond the version pulled into V8.

I suggest that we swap out source_map.js for this class, when I have the time to port it.
@bcoe bcoe added the source maps Issues and PRs related to source map support. label Jan 9, 2020
@bcoe bcoe mentioned this issue Jan 9, 2020
Closed
4 tasks
bcoe added a commit to bcoe/node-1 that referenced this issue Feb 24, 2020
@bcoe
module: port source map sorting logic from chromium
584bdd8 
Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.

fixes: nodejs#31286
@bcoe bcoe mentioned this issue Feb 24, 2020
Closed
4 tasks
@bcoe bcoe closed this as completed in fb26b13 Feb 28, 2020
codebytere pushed a commit that referenced this issue Feb 29, 2020
@bcoe @codebytere
module: port source map sort logic from chromium
9e3e676 
Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.

fixes: #31286

PR-URL: #31927
Fixes: #31286
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 25, 2020
@bcoe @targos
module: port source map sort logic from chromium
fcbb571 
Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.

fixes: nodejs#31286

PR-URL: nodejs#31927
Fixes: nodejs#31286
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 28, 2020
@bcoe @targos
module: port source map sort logic from chromium
b62db59 
Digging in to the delta between V8's source map library, and chromium's
the most significant difference that jumped out at me was that we were
failing to sort generated columns. Since negative offsets are not
restricted in the spec, this can lead to bugs.

fixes: #31286

PR-URL: #31927
Fixes: #31286
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
source maps Issues and PRs related to source map support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

module: port source map sorting logic from chromium bcoe/node-1
1 participant
@bcoe