Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node --help doesn't list values for --use-largepages=... #31533

Closed
bnoordhuis opened this issue Jan 27, 2020 · 0 comments · Fixed by #31537
Closed

node --help doesn't list values for --use-largepages=... #31533

bnoordhuis opened this issue Jan 27, 2020 · 0 comments · Fixed by #31537

Comments

@bnoordhuis
Copy link
Member 

$ node --help | grep -A2 -B1 use-largepages
  --use-bundled-ca            use bundled CA store (default)
  --use-largepages=...        Map the Node.js static code to large
                              pages
  --use-openssl-ca            use OpenSSL's default CA store

Not helpful...

For the record: the allowed values are off, on and silent.
@cjihrig cjihrig mentioned this issue Jan 27, 2020
Merged
3 tasks
@cjihrig cjihrig closed this as completed in 2272489 Feb 1, 2020
codebytere pushed a commit that referenced this issue Feb 17, 2020
@cjihrig @codebytere
doc: list largepage values in --help
faec87b 
This commit adds the supported --use-largepages values to
the --help menu.

PR-URL: #31537
Fixes: #31533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Apr 25, 2020
@cjihrig @targos
doc: list largepage values in --help
eaad4c9 
This commit adds the supported --use-largepages values to
the --help menu.

PR-URL: nodejs#31537
Fixes: nodejs#31533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Apr 28, 2020
@cjihrig @targos
doc: list largepage values in --help
9d9e185 
This commit adds the supported --use-largepages values to
the --help menu.

PR-URL: #31537
Fixes: #31533
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: list largepage values in --help cjihrig/node
1 participant
@bnoordhuis