-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'uncaughtException' event not working with unhandled promises #32907
Comments
You have an unhandled rejection, not an uncaught exception. They aren't the same thing. You could try looking into the |
FWIW, I just read through the docs, and I agree that they are confusing in this regard. |
I see that this issue is inactive so to work on any fix the more information are needed:
|
The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: nodejs#32907 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
@MrBartusek I opened #33530 to improve the documentation. Does that clarify the origin argument and the purpose of it? |
@BridgeAR Yes! That clarifies everything, thanks |
The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: #32907 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33530 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: #32907 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33530 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: #32907 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33530 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
What steps will reproduce the bug?
What is the expected behavior?
According to the documentation default node handling should be overwritten by this callback with
unhandledRejection
originWhat do you see instead?
Additional information
I think that is probably an error that documentation and origin variable suggests that
uncaughtException
can handle promises when we haveunhandledRejection
event.The text was updated successfully, but these errors were encountered: