-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast buffer.Blob parts into string as a fallback #37356
Comments
5 tasks
targos
added a commit
to targos/node
that referenced
this issue
Feb 16, 2021
targos
added a commit
to targos/node
that referenced
this issue
Feb 17, 2021
targos
added a commit
to targos/node
that referenced
this issue
Aug 8, 2021
PR-URL: nodejs#37361 Fixes: nodejs#37352 Fixes: nodejs#37356 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
to targos/node
that referenced
this issue
Aug 8, 2021
PR-URL: nodejs#37361 Fixes: nodejs#37352 Fixes: nodejs#37356 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
to targos/node
that referenced
this issue
Aug 13, 2021
PR-URL: nodejs#37361 Fixes: nodejs#37352 Fixes: nodejs#37356 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added a commit
that referenced
this issue
Aug 13, 2021
MylesBorins
pushed a commit
that referenced
this issue
Aug 31, 2021
foxxyz
pushed a commit
to foxxyz/node
that referenced
this issue
Oct 18, 2021
PR-URL: nodejs#37361 Backport-PR-URL: nodejs#39704 Fixes: nodejs#37352 Fixes: nodejs#37356 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
node/lib/internal/blob.js
Lines 86 to 98 in d4bea09
it should instead be casted into a string if you don't know how to handle the "blob part" not to throw a error
The text was updated successfully, but these errors were encountered: