--enable-source-maps throws internal TypeError when throwing non-object value #38945
Labels
source maps
Issues and PRs related to source map support.
Comments
|
@targos @ColinTimBarndt acknowledged. We should catch and suppress this specific error. |
bcoe
added a commit
to bcoe/node-1
that referenced
this issue
Jun 13, 2021
If an error is thrown before a module is loaded, we attempt to cache source map against error object, rather than module object. We can't do this if the error is a primitive type Fixes nodejs#38945
danielleadams
pushed a commit
that referenced
this issue
Jun 22, 2021
If an error is thrown before a module is loaded, we attempt to cache source map against error object, rather than module object. We can't do this if the error is a primitive type Fixes #38945 PR-URL: #39025 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
pushed a commit
that referenced
this issue
Jul 19, 2021
If an error is thrown before a module is loaded, we attempt to cache source map against error object, rather than module object. We can't do this if the error is a primitive type Fixes #38945 PR-URL: #39025 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
pushed a commit
that referenced
this issue
Jul 20, 2021
If an error is thrown before a module is loaded, we attempt to cache source map against error object, rather than module object. We can't do this if the error is a primitive type Fixes #38945 PR-URL: #39025 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this issue
Oct 18, 2021
If an error is thrown before a module is loaded, we attempt to cache source map against error object, rather than module object. We can't do this if the error is a primitive type Fixes nodejs#38945 PR-URL: nodejs#39025 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
Run
node --enable-source-maps test.jswheretest.jshas a SourceMap, it can be generated from this code:How often does it reproduce? Is there a required condition?
The thrown object must not be
typeof "object". When the error is thrown (and uncaught), throwing the error causes an internal error that does not expose any information about the source code that originally caused it.What is the expected behavior?
A correct stack trace should be generated either way.
What do you see instead?
TypeError: WeakRef: target must be an object at new WeakRef (<anonymous>) at new SafeWeakRef (node:internal/per_context/primordials:383:27) at IterableWeakMap.set (node:internal/util/iterable_weak_map:28:19) at rekeySourceMap (node:internal/source_map/source_map_cache:179:23) at Function.Module._load (node:internal/modules/cjs/loader:825:9) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12) at node:internal/main/run_main_module:17:47The text was updated successfully, but these errors were encountered: