Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings for primordials don't work anymore #40144

Closed
targos opened this issue Sep 18, 2021 · 0 comments
Closed

Typings for primordials don't work anymore #40144

targos opened this issue Sep 18, 2021 · 0 comments
Labels
typings

Comments

@targos
Copy link
Member

targos commented Sep 18, 2021

Visible with "checkJs": true:

image
@targos targos added the typings label Sep 18, 2021
targos added a commit to targos/node that referenced this issue Sep 26, 2021
@targos
typings: fix declaration of primordials
7764c93 
Closes: nodejs#40144
@github-actions github-actions bot mentioned this issue Oct 9, 2021
Closed
@targos targos closed this as completed in 9e64336 Oct 10, 2021
targos added a commit that referenced this issue Oct 13, 2021
@targos
typings: fix declaration of primordials
65b51d0 
PR-URL: #40222
Fixes: #40144
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@targos