Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: documentation should mention that maxFreeSockets is per host #40446

Closed
1 task
snytkine opened this issue Oct 13, 2021 · 1 comment
Closed
1 task

doc: documentation should mention that maxFreeSockets is per host #40446

snytkine opened this issue Oct 13, 2021 · 1 comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.

Comments

@snytkine
Copy link

snytkine commented Oct 13, 2021 •
edited
Loading

📗 API Reference Docs Problem

  • Version: ✍️16
  • Platform: ✍️MacOS
  • Subsystem: ✍️http

Location

Section of the site where the content exists

Affected URL(s):

Description

Concise explanation of the problem

✍️
Currently documentation says:
maxFreeSockets Maximum number of sockets to leave open in a free state.
But after lookin at the source code in _http_agent.js it looks to me that maxFreeSockets is the maximum number of free sockets per host, similar how maxSockets number is per host.

  • I would like to work on this issue and
    submit a pull request.
@snytkine snytkine added the doc Issues and PRs related to the documentations. label Oct 13, 2021
@Mesteery Mesteery added the http Issues or PRs related to the http subsystem. label Oct 13, 2021
@lpinca lpinca mentioned this issue Oct 16, 2021
Closed
lpinca added a commit to lpinca/node that referenced this issue Oct 16, 2021
@lpinca
doc: specify that maxFreeSockets is per host
a1209e4 
The `maxFreeSockets` options specifies the maximum number of free
sockets per host.

Fixes: nodejs#40446
lpinca added a commit to lpinca/node that referenced this issue Oct 16, 2021
@lpinca
doc: specify that maxFreeSockets is per host
1faecd2 
The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

Fixes: nodejs#40446
@lpinca lpinca closed this as completed in 78e8f08 Oct 19, 2021
targos pushed a commit that referenced this issue Oct 20, 2021
@lpinca @targos
doc: specify that maxFreeSockets is per host
977016a 
The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

PR-URL: #40483
Fixes: #40446
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this issue Nov 4, 2021
@lpinca @targos
doc: specify that maxFreeSockets is per host
7b74638 
The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

PR-URL: #40483
Fixes: #40446
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Samjin
Copy link

Samjin commented Nov 2, 2022

What is the difference between using maxSockets vs maxFreeSockets then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: specify that maxFreeSockets is per host lpinca/node
3 participants
@snytkine @Samjin @Mesteery